Re: [Qemu-devel] [PATCH v2 13/14] sm501: Add reset function and vmstate descriptor

2017-03-02 Thread Peter Maydell
On 2 March 2017 at 20:55, BALATON Zoltan wrote: > On Thu, 2 Mar 2017, Peter Maydell wrote: >> >> On 2 March 2017 at 20:18, BALATON Zoltan wrote: >>> >>> On Thu, 2 Mar 2017, Peter Maydell wrote: Don't use qemu_register_reset(). Set the appropriate dc->reset function pointers in

Re: [Qemu-devel] [PATCH v2 13/14] sm501: Add reset function and vmstate descriptor

2017-03-02 Thread BALATON Zoltan
On Thu, 2 Mar 2017, BALATON Zoltan wrote: On Thu, 2 Mar 2017, Peter Maydell wrote: On 2 March 2017 at 20:18, BALATON Zoltan wrote: On Thu, 2 Mar 2017, Peter Maydell wrote: Don't use qemu_register_reset(). Set the appropriate dc->reset function pointers instead. Any reason for that? This w

Re: [Qemu-devel] [PATCH v2 13/14] sm501: Add reset function and vmstate descriptor

2017-03-02 Thread BALATON Zoltan
On Thu, 2 Mar 2017, Peter Maydell wrote: On 2 March 2017 at 20:18, BALATON Zoltan wrote: On Thu, 2 Mar 2017, Peter Maydell wrote: Don't use qemu_register_reset(). Set the appropriate dc->reset function pointers instead. Any reason for that? This way I could save two more boilerplate functi

Re: [Qemu-devel] [PATCH v2 13/14] sm501: Add reset function and vmstate descriptor

2017-03-02 Thread Peter Maydell
On 2 March 2017 at 20:18, BALATON Zoltan wrote: > On Thu, 2 Mar 2017, Peter Maydell wrote: >> >> Don't use qemu_register_reset(). Set the appropriate dc->reset >> function pointers instead. > > > Any reason for that? This way I could save two more boilerplate functions > because I could define res

Re: [Qemu-devel] [PATCH v2 13/14] sm501: Add reset function and vmstate descriptor

2017-03-02 Thread BALATON Zoltan
On Thu, 2 Mar 2017, Peter Maydell wrote: On 25 February 2017 at 23:53, BALATON Zoltan wrote: Signed-off-by: BALATON Zoltan --- hw/display/sm501.c | 110 ++--- 1 file changed, 105 insertions(+), 5 deletions(-) diff --git a/hw/display/sm501.c b/h

Re: [Qemu-devel] [PATCH v2 13/14] sm501: Add reset function and vmstate descriptor

2017-03-02 Thread Peter Maydell
On 25 February 2017 at 23:53, BALATON Zoltan wrote: > Signed-off-by: BALATON Zoltan > --- > hw/display/sm501.c | 110 > ++--- > 1 file changed, 105 insertions(+), 5 deletions(-) > > diff --git a/hw/display/sm501.c b/hw/display/sm501.c > index 3222

[Qemu-devel] [PATCH v2 13/14] sm501: Add reset function and vmstate descriptor

2017-02-25 Thread BALATON Zoltan
Signed-off-by: BALATON Zoltan --- hw/display/sm501.c | 110 ++--- 1 file changed, 105 insertions(+), 5 deletions(-) diff --git a/hw/display/sm501.c b/hw/display/sm501.c index 32223f6..b682a95 100644 --- a/hw/display/sm501.c +++ b/hw/display/sm501.c