Re: [Qemu-devel] [PATCH v2 13/14] commit: Use BlockBackend for I/O

2016-05-24 Thread Eric Blake
On 05/24/2016 09:51 PM, Changlong Xie wrote: > On 05/24/2016 09:47 PM, Kevin Wolf wrote: >> +s->base = blk_new(); > blk_new(errp); >> +blk_insert_bs(s->base, base); >> + >> +s->top = blk_new(); > blk_new(errp); Wrong. Even if it weren't for basing it on top of Kevin's branch which remo

Re: [Qemu-devel] [PATCH v2 13/14] commit: Use BlockBackend for I/O

2016-05-24 Thread Changlong Xie
On 05/24/2016 09:47 PM, Kevin Wolf wrote: +s->base = blk_new(); blk_new(errp); +blk_insert_bs(s->base, base); + +s->top = blk_new(); blk_new(errp);

Re: [Qemu-devel] [PATCH v2 13/14] commit: Use BlockBackend for I/O

2016-05-24 Thread Eric Blake
On 05/24/2016 07:47 AM, Kevin Wolf wrote: > This changes the commit block job to use the job's BlockBackend for > performing its I/O. job->bs isn't used by the commit code any more > afterwards. > > Signed-off-by: Kevin Wolf > --- > block/commit.c | 53 +--

[Qemu-devel] [PATCH v2 13/14] commit: Use BlockBackend for I/O

2016-05-24 Thread Kevin Wolf
This changes the commit block job to use the job's BlockBackend for performing its I/O. job->bs isn't used by the commit code any more afterwards. Signed-off-by: Kevin Wolf --- block/commit.c | 53 + 1 file changed, 33 insertions(+), 20 deletio