Re: [Qemu-devel] [PATCH v2 13/13] migration: remove notify in fd_error

2018-01-03 Thread Peter Xu
On Wed, Jan 03, 2018 at 01:31:01PM +0100, Juan Quintela wrote: > Peter Xu wrote: > > It should be called in migrate_fd_cleanup too. > > It is *already* called in migrate_fd_cleanup. > > I think we should add a comment stating that we _always_ end calling > migrate_fd_cleanup, independently of ho

Re: [Qemu-devel] [PATCH v2 13/13] migration: remove notify in fd_error

2018-01-03 Thread Juan Quintela
Peter Xu wrote: > It should be called in migrate_fd_cleanup too. It is *already* called in migrate_fd_cleanup. I think we should add a comment stating that we _always_ end calling migrate_fd_cleanup, independently of how the migration ends. > Signed-off-by: Peter Xu Reviewed-by: Juan Quintel

[Qemu-devel] [PATCH v2 13/13] migration: remove notify in fd_error

2018-01-03 Thread Peter Xu
It should be called in migrate_fd_cleanup too. Signed-off-by: Peter Xu --- migration/migration.c | 1 - 1 file changed, 1 deletion(-) diff --git a/migration/migration.c b/migration/migration.c index fbb41b8887..c671f0a662 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -1129,7