Re: [Qemu-devel] [PATCH v2 12/25] target-arm: Update generic cpreg code for AArch64

2014-01-04 Thread Peter Crosthwaite
On Sun, Jan 5, 2014 at 5:58 AM, Peter Maydell wrote: > On 2 January 2014 01:51, Peter Crosthwaite > wrote: >> On Mon, Dec 23, 2013 at 8:49 AM, Peter Maydell >> wrote: >>> +#define ARM_CP_STATE_AA32 0 >>> +#define ARM_CP_STATE_AA64 1 >>> +#define ARM_CP_STATE_BOTH 2 >> >> You iterator below dep

Re: [Qemu-devel] [PATCH v2 12/25] target-arm: Update generic cpreg code for AArch64

2014-01-04 Thread Peter Maydell
On 2 January 2014 01:51, Peter Crosthwaite wrote: > On Mon, Dec 23, 2013 at 8:49 AM, Peter Maydell > wrote: >> +#define ARM_CP_STATE_AA32 0 >> +#define ARM_CP_STATE_AA64 1 >> +#define ARM_CP_STATE_BOTH 2 > > You iterator below depends on this specific encoding ordering, so > maybe this should be

Re: [Qemu-devel] [PATCH v2 12/25] target-arm: Update generic cpreg code for AArch64

2014-01-02 Thread Peter Maydell
On 2 January 2014 01:51, Peter Crosthwaite wrote: > On Mon, Dec 23, 2013 at 8:49 AM, Peter Maydell > wrote: >> +/* Valid values for ARMCPRegInfo state field, indicating which of >> + * the AArch32 and AArch64 execution states this register is visible in. >> + * If the reginfo doesn't explicitly

Re: [Qemu-devel] [PATCH v2 12/25] target-arm: Update generic cpreg code for AArch64

2014-01-01 Thread Peter Crosthwaite
On Mon, Dec 23, 2013 at 8:49 AM, Peter Maydell wrote: > Update the generic cpreg support code to also handle AArch64: > AArch64-visible registers coexist in the same hash table with > AArch32-visible ones, with a bit in the hash key distinguishing > them. > > Signed-off-by: Peter Maydell > --- >

[Qemu-devel] [PATCH v2 12/25] target-arm: Update generic cpreg code for AArch64

2013-12-22 Thread Peter Maydell
Update the generic cpreg support code to also handle AArch64: AArch64-visible registers coexist in the same hash table with AArch32-visible ones, with a bit in the hash key distinguishing them. Signed-off-by: Peter Maydell --- target-arm/cpu.h| 74 +++--- tar