Re: [Qemu-devel] [PATCH v2 12/13] ucontext: annotate coroutine stack for ASAN

2017-12-18 Thread Stefan Hajnoczi
On Fri, Dec 15, 2017 at 04:06:58PM +0100, Marc-André Lureau wrote: > It helps ASAN to detect more leaks on coroutine stacks, as found in > the following patch. > > A similar work would need to be done for sigaltstack & windows fibers > to have similar coverage. Since ucontext is prefered, I didn't

Re: [Qemu-devel] [PATCH v2 12/13] ucontext: annotate coroutine stack for ASAN

2017-12-15 Thread Eric Blake
On 12/15/2017 09:06 AM, Marc-André Lureau wrote: > It helps ASAN to detect more leaks on coroutine stacks, as found in > the following patch. > > A similar work would need to be done for sigaltstack & windows fibers > to have similar coverage. Since ucontext is prefered, I didn't bother s/prefere

Re: [Qemu-devel] [PATCH v2 12/13] ucontext: annotate coroutine stack for ASAN

2017-12-15 Thread Philippe Mathieu-Daudé
On 12/15/2017 12:06 PM, Marc-André Lureau wrote: > It helps ASAN to detect more leaks on coroutine stacks, as found in > the following patch. Nice! > A similar work would need to be done for sigaltstack & windows fibers > to have similar coverage. Since ucontext is prefered, I didn't bother > che

[Qemu-devel] [PATCH v2 12/13] ucontext: annotate coroutine stack for ASAN

2017-12-15 Thread Marc-André Lureau
It helps ASAN to detect more leaks on coroutine stacks, as found in the following patch. A similar work would need to be done for sigaltstack & windows fibers to have similar coverage. Since ucontext is prefered, I didn't bother checking the other coroutine implementations for now. Signed-off-by: