Re: [Qemu-devel] [PATCH v2 11/45] exec-all: bring tb->invalid into tb->cflags

2017-07-17 Thread Emilio G. Cota
On Mon, Jul 17, 2017 at 13:07:53 -1000, Richard Henderson wrote: > On 07/16/2017 10:03 AM, Emilio G. Cota wrote: > >-tb->invalid = true; > >+tb->cflags |= CF_INVALID; > > Modulo the store_release comment for the last patch, same thing: note tb_lock is always held when checking the flag, a

Re: [Qemu-devel] [PATCH v2 11/45] exec-all: bring tb->invalid into tb->cflags

2017-07-17 Thread Richard Henderson
On 07/16/2017 10:03 AM, Emilio G. Cota wrote: -tb->invalid = true; +tb->cflags |= CF_INVALID; Modulo the store_release comment for the last patch, Reviewed-by: Richard Henderson r~

[Qemu-devel] [PATCH v2 11/45] exec-all: bring tb->invalid into tb->cflags

2017-07-16 Thread Emilio G. Cota
This gets rid of a hole in struct TranslationBlock. Signed-off-by: Emilio G. Cota --- include/exec/exec-all.h | 3 +-- accel/tcg/cpu-exec.c | 2 +- accel/tcg/translate-all.c | 3 +-- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/include/exec/exec-all.h b/include/exec/exec