Re: [Qemu-devel] [PATCH v2 10/36] target-microblaze: Bypass MMU with MMU_NOMMU_IDX

2018-05-15 Thread Edgar E. Iglesias
On Wed, May 09, 2018 at 01:51:31PM -0700, Richard Henderson wrote: > On 05/08/2018 10:31 AM, Edgar E. Iglesias wrote: > > +if (cpu->cfg.use_mmu && (env->sregs[SR_MSR] & MSR_VM) > > +&& mmu_idx != MMU_NOMMU_IDX) { > > For future cleanup, the first condition should be moved to cpu_mmu_in

Re: [Qemu-devel] [PATCH v2 10/36] target-microblaze: Bypass MMU with MMU_NOMMU_IDX

2018-05-09 Thread Richard Henderson
On 05/08/2018 10:31 AM, Edgar E. Iglesias wrote: > +if (cpu->cfg.use_mmu && (env->sregs[SR_MSR] & MSR_VM) > +&& mmu_idx != MMU_NOMMU_IDX) { For future cleanup, the first condition should be moved to cpu_mmu_index (the second condition is already there). At which point here you need ch

[Qemu-devel] [PATCH v2 10/36] target-microblaze: Bypass MMU with MMU_NOMMU_IDX

2018-05-08 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Bypass MMU translation when mmu-index MMU_NOMMU_IDX is used. Reviewed-by: Alistair Francis Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias --- target/microblaze/helper.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/mic