Re: [Qemu-devel] [PATCH v2 10/17] virtio-scsi: use standard-headers

2015-03-11 Thread Alexey Kardashevskiy
On 03/11/2015 11:04 PM, Michael S. Tsirkin wrote: On Wed, Mar 11, 2015 at 09:13:18PM +1100, Alexey Kardashevskiy wrote: Hi! This particular patch broke virtio-scsi in SLOF (ppc64-server firmware), QEMU just exits: Populating /pci@8002000/scsi@0 SCSI: Looking for devices qemu-sy

Re: [Qemu-devel] [PATCH v2 10/17] virtio-scsi: use standard-headers

2015-03-11 Thread Michael S. Tsirkin
On Wed, Mar 11, 2015 at 09:13:18PM +1100, Alexey Kardashevskiy wrote: > Hi! > > This particular patch broke virtio-scsi in SLOF (ppc64-server firmware), > QEMU just exits: > > Populating /pci@8002000/scsi@0 >SCSI: Looking for devices > qemu-system-ppc64: wrong size for virtio-scsi

Re: [Qemu-devel] [PATCH v2 10/17] virtio-scsi: use standard-headers

2015-03-11 Thread Alexey Kardashevskiy
On 03/11/2015 09:13 PM, Alexey Kardashevskiy wrote: Hi! This particular patch broke virtio-scsi in SLOF (ppc64-server firmware), QEMU just exits: Oops, there was v3 and Nikunj asked there. Ignore this. Populating /pci@8002000/scsi@0 SCSI: Looking for devices qemu-system-ppc

Re: [Qemu-devel] [PATCH v2 10/17] virtio-scsi: use standard-headers

2015-03-11 Thread Alexey Kardashevskiy
Hi! This particular patch broke virtio-scsi in SLOF (ppc64-server firmware), QEMU just exits: Populating /pci@8002000/scsi@0 SCSI: Looking for devices qemu-system-ppc64: wrong size for virtio-scsi headers This is how I run it: -device virtio-scsi-pci,id=id3 \ -drive id=id4,if

Re: [Qemu-devel] [PATCH v2 10/17] virtio-scsi: use standard-headers

2015-02-16 Thread Paolo Bonzini
On 16/02/2015 12:45, Peter Maydell wrote: > My point was that you don't want to be including > these headers via "linux/whatever.h"; > #include "standard-headers/linux/whatever.h" would be > fine. I agree on both counts. Paolo

Re: [Qemu-devel] [PATCH v2 10/17] virtio-scsi: use standard-headers

2015-02-16 Thread Peter Maydell
On 16 February 2015 at 11:36, Michael S. Tsirkin wrote: > On Mon, Feb 16, 2015 at 10:30:24AM +0100, Paolo Bonzini wrote: >> >> >> On 15/02/2015 12:39, Michael S. Tsirkin wrote: >> > Drop duplicated code. >> > >> > Signed-off-by: Michael S. Tsirkin >> > --- >> > include/hw/virtio/virtio-scsi.h |

Re: [Qemu-devel] [PATCH v2 10/17] virtio-scsi: use standard-headers

2015-02-16 Thread Michael S. Tsirkin
On Mon, Feb 16, 2015 at 10:30:24AM +0100, Paolo Bonzini wrote: > > > On 15/02/2015 12:39, Michael S. Tsirkin wrote: > > Drop duplicated code. > > > > Signed-off-by: Michael S. Tsirkin > > --- > > include/hw/virtio/virtio-scsi.h | 120 > > +++- > > hw/scsi/v

Re: [Qemu-devel] [PATCH v2 10/17] virtio-scsi: use standard-headers

2015-02-16 Thread Paolo Bonzini
On 15/02/2015 12:39, Michael S. Tsirkin wrote: > Drop duplicated code. > > Signed-off-by: Michael S. Tsirkin > --- > include/hw/virtio/virtio-scsi.h | 120 > +++- > hw/scsi/virtio-scsi.c | 1 + > 2 files changed, 10 insertions(+), 111 deletions(

[Qemu-devel] [PATCH v2 10/17] virtio-scsi: use standard-headers

2015-02-15 Thread Michael S. Tsirkin
Drop duplicated code. Signed-off-by: Michael S. Tsirkin --- include/hw/virtio/virtio-scsi.h | 120 +++- hw/scsi/virtio-scsi.c | 1 + 2 files changed, 10 insertions(+), 111 deletions(-) diff --git a/include/hw/virtio/virtio-scsi.h b/include/hw/virt