Re: [Qemu-devel] [PATCH v2 10/10] target-arm: fix neon shift helper functions

2009-10-25 Thread Laurent Desnogues
On Sat, Oct 24, 2009 at 1:19 PM, wrote: > From: Juha Riihimäki > > Current code is broken at least on gcc 4.2, the result of a comparison > "-1 >= sizeof(type) * 8" results true and causes wrong code path to > be taken. The fix has been revised to use a type cast instead of > abs() function and

[Qemu-devel] [PATCH v2 10/10] target-arm: fix neon shift helper functions

2009-10-24 Thread juha . riihimaki
From: Juha Riihimäki Current code is broken at least on gcc 4.2, the result of a comparison "-1 >= sizeof(type) * 8" results true and causes wrong code path to be taken. The fix has been revised to use a type cast instead of abs() function and extra checks. Signed-off-by: Juha Riihimäki --- ta