Re: [Qemu-devel] [PATCH v2 10/10] file-posix: Make auto-read-only dynamic

2019-03-11 Thread Markus Armbruster
Peter Krempa writes: > On Mon, Mar 11, 2019 at 15:10:36 -0500, Eric Blake wrote: >> On 3/11/19 2:59 PM, Peter Krempa wrote: >> >> >> auto-read-only was introduced in 3.1, at which point we intentionally >> >> had sufficiently loose wording to permit (but not require) dynamic state >> >> checking

Re: [Qemu-devel] [PATCH v2 10/10] file-posix: Make auto-read-only dynamic

2019-03-11 Thread Peter Krempa
On Mon, Mar 11, 2019 at 15:10:36 -0500, Eric Blake wrote: > On 3/11/19 2:59 PM, Peter Krempa wrote: > > >> auto-read-only was introduced in 3.1, at which point we intentionally > >> had sufficiently loose wording to permit (but not require) dynamic state > >> checking; so you are not breaking the

Re: [Qemu-devel] [PATCH v2 10/10] file-posix: Make auto-read-only dynamic

2019-03-11 Thread Eric Blake
On 3/11/19 2:59 PM, Peter Krempa wrote: >> auto-read-only was introduced in 3.1, at which point we intentionally >> had sufficiently loose wording to permit (but not require) dynamic state >> checking; so you are not breaking the interface. On the other hand, is >> libvirt going to have problems

Re: [Qemu-devel] [PATCH v2 10/10] file-posix: Make auto-read-only dynamic

2019-03-11 Thread Peter Krempa
On Mon, Mar 11, 2019 at 12:26:08 -0500, Eric Blake wrote: > On 3/11/19 11:50 AM, Kevin Wolf wrote: > > Until now, with auto-read-only=on we tried to open the file read-write > > first and if that failed, read-only was tried. This is actually not good > > enough for libvirt, which gives QEMU SELinux

Re: [Qemu-devel] [PATCH v2 10/10] file-posix: Make auto-read-only dynamic

2019-03-11 Thread Eric Blake
On 3/11/19 11:50 AM, Kevin Wolf wrote: > Until now, with auto-read-only=on we tried to open the file read-write > first and if that failed, read-only was tried. This is actually not good > enough for libvirt, which gives QEMU SELinux permissions for read-write > only as soon as it actually intends

[Qemu-devel] [PATCH v2 10/10] file-posix: Make auto-read-only dynamic

2019-03-11 Thread Kevin Wolf
Until now, with auto-read-only=on we tried to open the file read-write first and if that failed, read-only was tried. This is actually not good enough for libvirt, which gives QEMU SELinux permissions for read-write only as soon as it actually intends to write to the image. So we need to be able to