On 12 December 2013 12:14, C Fontana wrote:
> I think that there is more than the missing return:
>
> we need to handle the case 0 as well, as it's a perfectly valid form
> of a load/store pair:
> it's the Load/Store no-allocate pair (offset) (LDNP, STNP).
>
> So in my view we need to add a case 0
On 12 December 2013 12:45, Peter Maydell wrote:
> On 12 December 2013 11:43, Alex Bennée wrote:
>>
>> claudio.font...@linaro.org writes:
>>
>>> Hi,
>>>
>>> I saw a missing return below:
>>
+default: /* Failed decoder tree? */
+unallocated_encoding(s);
+break;
>
On 12 December 2013 11:43, Alex Bennée wrote:
>
> claudio.font...@linaro.org writes:
>
>> Hi,
>>
>> I saw a missing return below:
>
>>> +default: /* Failed decoder tree? */
>>> +unallocated_encoding(s);
>>> +break;
>>> +}
>>
>> This doesn't seem right (break instead of ret
claudio.font...@linaro.org writes:
> Hi,
>
> I saw a missing return below:
>> +default: /* Failed decoder tree? */
>> +unallocated_encoding(s);
>> +break;
>> +}
>
> This doesn't seem right (break instead of return):
>
> default:
> unallocated_encoding(s);
> return
Hi,
I saw a missing return below:
On 11 December 2013 23:01, Peter Maydell wrote:
> From: Alex Bennée
>
> This patch support the basic load and store pair instructions and
> includes the generic helper functions:
>
> * do_gpr_st()
> * do_fp_st()
> * do_gpr_ld()
> * do_fp_ld()
> * read
From: Alex Bennée
This patch support the basic load and store pair instructions and
includes the generic helper functions:
* do_gpr_st()
* do_fp_st()
* do_gpr_ld()
* do_fp_ld()
* read_cpu_reg_sp()
* gen_check_sp_alignment()
The last function gen_check_sp_alignment() is a NULL op cur
