Re: [Qemu-devel] [PATCH v2 1/8] CODING_STYLE: Section about conditional statement

2014-07-31 Thread Gonglei (Arei)
Hi, > Subject: Re: [PATCH v2 1/8] CODING_STYLE: Section about conditional > statement > > On 07/31/2014 08:32 PM, arei.gong...@huawei.com wrote: > > From: Gonglei > > > > Yoda conidtions lack of readability, and QEMU have a > > s/conidtions/conditions/ > s/of // > s/have/has/ > OK. > > strict

Re: [Qemu-devel] [PATCH v2 1/8] CODING_STYLE: Section about conditional statement

2014-07-31 Thread Eric Blake
On 07/31/2014 08:32 PM, arei.gong...@huawei.com wrote: > From: Gonglei > > Yoda conidtions lack of readability, and QEMU have a s/conidtions/conditions/ s/of // s/have/has/ > strict compiler configuration for checking a common > mistake like "if (dev = NULL)". Make it a written rule. > > Signe

[Qemu-devel] [PATCH v2 1/8] CODING_STYLE: Section about conditional statement

2014-07-31 Thread arei.gonglei
From: Gonglei Yoda conidtions lack of readability, and QEMU have a strict compiler configuration for checking a common mistake like "if (dev = NULL)". Make it a written rule. Signed-off-by: Gonglei --- CODING_STYLE | 19 +++ 1 file changed, 19 insertions(+) diff --git a/CODING