Re: [Qemu-devel] [PATCH v2 1/7] qdev: Deprecated qdev_init() is finally unused, drop

2015-06-19 Thread Markus Armbruster
Andreas Färber writes: > Hi Markus, > > Could you please add a verbose rationale here like "qdev_init() does not > propagate the Error* and should be replaced by ..."? What about: qdev_init() is a wrapper around setting property "realized" to true plus error handling, which passes error

Re: [Qemu-devel] [PATCH v2 1/7] qdev: Deprecated qdev_init() is finally unused, drop

2015-06-19 Thread Andreas Färber
Hi Markus, Could you please add a verbose rationale here like "qdev_init() does not propagate the Error* and should be replaced by ..."? Am 13.06.2015 um 13:18 schrieb Markus Armbruster: > Signed-off-by: Markus Armbruster > Reviewed-by: Eric Blake > --- > hw/core/qdev.c | 47 ++

[Qemu-devel] [PATCH v2 1/7] qdev: Deprecated qdev_init() is finally unused, drop

2015-06-13 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- hw/core/qdev.c | 47 --- include/hw/qdev-core.h | 3 +-- 2 files changed, 17 insertions(+), 33 deletions(-) diff --git a/hw/core/qdev.c b/hw/core/qdev.c index b0f0f84..d433675 10064