Re: [Qemu-devel] [PATCH v2 1/6] virtio: assert on ->inuse underflow

2016-08-23 Thread Michael S. Tsirkin
On Tue, Aug 23, 2016 at 05:03:32PM -0400, Stefan Hajnoczi wrote: > On Fri, Aug 19, 2016 at 04:39:20PM +0300, Roman Kagan wrote: > > Make sure that ->inuse counter on virtqueue never goes negative. > > > > This complements commit afd9096eb1882f23929f5b5c177898ed231bac66, > > "virtio: error out if g

Re: [Qemu-devel] [PATCH v2 1/6] virtio: assert on ->inuse underflow

2016-08-23 Thread Stefan Hajnoczi
On Fri, Aug 19, 2016 at 04:39:20PM +0300, Roman Kagan wrote: > Make sure that ->inuse counter on virtqueue never goes negative. > > This complements commit afd9096eb1882f23929f5b5c177898ed231bac66, > "virtio: error out if guest exceeds virtqueue size", which, due to > signed ->inuse comparison aga

[Qemu-devel] [PATCH v2 1/6] virtio: assert on ->inuse underflow

2016-08-19 Thread Roman Kagan
Make sure that ->inuse counter on virtqueue never goes negative. This complements commit afd9096eb1882f23929f5b5c177898ed231bac66, "virtio: error out if guest exceeds virtqueue size", which, due to signed ->inuse comparison against unsigned ->vring.num, manifested a bug in virtio-balloon where vir