Re: [Qemu-devel] [PATCH v2 1/6] qerror: add MAX_KEYCODES 16

2012-06-19 Thread Amos Kong
On 18/06/12 23:30, Amos Kong wrote: On 06/15/2012 09:35 PM, Luiz Capitulino wrote: On Fri, 15 Jun 2012 09:57:49 +0200 Gerd Hoffmann wrote: Hi, It seems we need to notice user when inputted keys are more than 16. Hi Gerd, When I use 'sendkey' command to send key-series to guest, some k

Re: [Qemu-devel] [PATCH v2 1/6] qerror: add MAX_KEYCODES 16

2012-06-18 Thread Amos Kong
On 06/15/2012 09:35 PM, Luiz Capitulino wrote: > On Fri, 15 Jun 2012 09:57:49 +0200 > Gerd Hoffmann wrote: > >> Hi, >> It seems we need to notice user when inputted keys are more than 16. >>> >>> Hi Gerd, >>> >>> When I use 'sendkey' command to send key-series to guest, some keyboard >>> e

Re: [Qemu-devel] [PATCH v2 1/6] qerror: add MAX_KEYCODES 16

2012-06-15 Thread Luiz Capitulino
On Fri, 15 Jun 2012 09:57:49 +0200 Gerd Hoffmann wrote: > Hi, > > >> It seems we need to notice user when inputted keys are more than 16. > > > > Hi Gerd, > > > > When I use 'sendkey' command to send key-series to guest, some keyboard > > events will be send. There is a limitation (16) that

Re: [Qemu-devel] [PATCH v2 1/6] qerror: add MAX_KEYCODES 16

2012-06-15 Thread Gerd Hoffmann
Hi, >> It seems we need to notice user when inputted keys are more than 16. > > Hi Gerd, > > When I use 'sendkey' command to send key-series to guest, some keyboard > events will be send. There is a limitation (16) that was introduced by this > old commit c8256f9d (without description). Do you

Re: [Qemu-devel] [PATCH v2 1/6] qerror: add MAX_KEYCODES 16

2012-06-15 Thread Amos Kong
On 14/06/12 18:20, Amos Kong wrote: On 12/06/12 01:25, Luiz Capitulino wrote: Hi Luiz, Anthony BTW, why is there a 16 keycode limit? 'Sendkey' command was added by this commit a3a91a355bc6107b7d06d722fb97d2b80065ee0b Limitation of keycodes number (16) was also introduced here, and I didn'

Re: [Qemu-devel] [PATCH v2 1/6] qerror: add MAX_KEYCODES 16

2012-06-14 Thread Amos Kong
On 12/06/12 01:25, Luiz Capitulino wrote: Hi Luiz, Anthony BTW, why is there a 16 keycode limit? 'Sendkey' command was added by this commit a3a91a355bc6107b7d06d722fb97d2b80065ee0b Limitation of keycodes number (16) was also introduced here, and I didn't find the root reason. That's

Re: [Qemu-devel] [PATCH v2 1/6] qerror: add MAX_KEYCODES 16

2012-06-05 Thread Amos Kong
- Original Message - > On 06/02/2012 06:54 AM, Amos Kong wrote: > > Signed-off-by: Amos Kong > > I think QERR_INVALID_PARAMETER_VALUE is a more logical choice for the > error > you're generating. I used this new error in [PATCH 6/6], if user inputs more than 16 keys once, this error will