Re: [Qemu-devel] [PATCH v2 1/6] error: Add error_abort

2013-12-06 Thread Markus Armbruster
Peter Crosthwaite writes: > On Fri, Dec 6, 2013 at 9:59 PM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> On 12/05/2013 03:13 AM, Markus Armbruster wrote: >>> > > For error_propagate, if the destination error is &error_abort, then > the abort happens at propagation time. >>>

Re: [Qemu-devel] [PATCH v2 1/6] error: Add error_abort

2013-12-06 Thread Peter Crosthwaite
On Fri, Dec 6, 2013 at 9:59 PM, Markus Armbruster wrote: > Eric Blake writes: > >> On 12/05/2013 03:13 AM, Markus Armbruster wrote: >> For error_propagate, if the destination error is &error_abort, then the abort happens at propagation time. Signed-off-by: Peter Crosthwai

Re: [Qemu-devel] [PATCH v2 1/6] error: Add error_abort

2013-12-06 Thread Markus Armbruster
Eric Blake writes: > On 12/05/2013 03:13 AM, Markus Armbruster wrote: > >>> >>> For error_propagate, if the destination error is &error_abort, then >>> the abort happens at propagation time. >>> >>> Signed-off-by: Peter Crosthwaite >>> --- >>> changed since v1: >>> Delayed assertions that *errp

Re: [Qemu-devel] [PATCH v2 1/6] error: Add error_abort

2013-12-05 Thread Eric Blake
On 12/05/2013 03:13 AM, Markus Armbruster wrote: >> >> For error_propagate, if the destination error is &error_abort, then >> the abort happens at propagation time. >> >> Signed-off-by: Peter Crosthwaite >> --- >> changed since v1: >> Delayed assertions that *errp == NULL. > > Care to explain wh

Re: [Qemu-devel] [PATCH v2 1/6] error: Add error_abort

2013-12-05 Thread Markus Armbruster
Peter Crosthwaite writes: > Add a special Error * that can be passed to error handling APIs to > signal that any errors are fatal and should abort QEMU. There are two > advantages to this: > > - allows for brevity when wishing to assert success of Error ** > accepting APIs. No need for this pat

[Qemu-devel] [PATCH v2 1/6] error: Add error_abort

2013-12-04 Thread Peter Crosthwaite
Add a special Error * that can be passed to error handling APIs to signal that any errors are fatal and should abort QEMU. There are two advantages to this: - allows for brevity when wishing to assert success of Error ** accepting APIs. No need for this pattern: Error * local_err = NULL;