Re: [Qemu-devel] [PATCH v2 1/5] target-m68k: fix bit operation with immediate value

2017-01-13 Thread Richard Henderson
On 01/13/2017 10:23 AM, Laurent Vivier wrote: > See "BSET Instruction Format:BIT NUMBER STATIC, SPECIFIED AS IMMEDIATE > DATA", p. 4.58 of "M68000 FAMILY PROGRAMMER’S REFERENCE MANUAL", "BIT > NUMBER" is bits 0 to 8 of extended word. Oops, yep. I misread that. Reviewed-by: Richard Henderson r

Re: [Qemu-devel] [PATCH v2 1/5] target-m68k: fix bit operation with immediate value

2017-01-13 Thread Laurent Vivier
Le 13/01/2017 à 18:55, Richard Henderson a écrit : > On 01/13/2017 04:51 AM, Laurent Vivier wrote: >> M680x0 bit operations with an immediate value use 9 bits of the 16bit >> value, while coldfire ones use only 8 bits. > > I don't see that in the reference manual. Where do you get this from? See

Re: [Qemu-devel] [PATCH v2 1/5] target-m68k: fix bit operation with immediate value

2017-01-13 Thread Richard Henderson
On 01/13/2017 04:51 AM, Laurent Vivier wrote: > M680x0 bit operations with an immediate value use 9 bits of the 16bit > value, while coldfire ones use only 8 bits. I don't see that in the reference manual. Where do you get this from? r~

[Qemu-devel] [PATCH v2 1/5] target-m68k: fix bit operation with immediate value

2017-01-13 Thread Laurent Vivier
M680x0 bit operations with an immediate value use 9 bits of the 16bit value, while coldfire ones use only 8 bits. Signed-off-by: Laurent Vivier --- target/m68k/translate.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/target/m68k/translate.c b/target/m68k/tra