Re: [Qemu-devel] [PATCH v2 1/5] msix_init: assert programming error

2016-10-06 Thread Cao jin
On 09/30/2016 10:06 PM, Markus Armbruster wrote: Alex Williamson writes: Once there's a need to handle a certain condition as an error, we should do that, no argument. This also provides a way to test the error path. However, I wouldn't buy an argument that preconditions should be made

Re: [Qemu-devel] [PATCH v2 1/5] msix_init: assert programming error

2016-10-04 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert" writes: > > > * Markus Armbruster (arm...@redhat.com) wrote: > >> Alex Williamson writes: > >> > >> > On Thu, 29 Sep 2016 15:11:27 +0200 > >> > Markus Armbruster wrote: > >> > > >> >> Alex Williamson writes: > >> >> >

Re: [Qemu-devel] [PATCH v2 1/5] msix_init: assert programming error

2016-10-04 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> Alex Williamson writes: >> >> > On Thu, 29 Sep 2016 15:11:27 +0200 >> > Markus Armbruster wrote: >> > >> >> Alex Williamson writes: >> >> >> >> > On Tue, 13 Sep 2016 08:16:20 +0200 >> >> > Markus Armbruster

Re: [Qemu-devel] [PATCH v2 1/5] msix_init: assert programming error

2016-09-30 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > Alex Williamson writes: > > > On Thu, 29 Sep 2016 15:11:27 +0200 > > Markus Armbruster wrote: > > > >> Alex Williamson writes: > >> > >> > On Tue, 13 Sep 2016 08:16:20 +0200 > >> > Markus Armbruster wrote: > >> > > >> >> Cc: Alex for device a

Re: [Qemu-devel] [PATCH v2 1/5] msix_init: assert programming error

2016-09-30 Thread Markus Armbruster
Alex Williamson writes: > On Thu, 29 Sep 2016 15:11:27 +0200 > Markus Armbruster wrote: > >> Alex Williamson writes: >> >> > On Tue, 13 Sep 2016 08:16:20 +0200 >> > Markus Armbruster wrote: >> > >> >> Cc: Alex for device assignment expertise. >> >> >> >> Cao jin writes: >> >> >> >> > O

Re: [Qemu-devel] [PATCH v2 1/5] msix_init: assert programming error

2016-09-29 Thread Alex Williamson
On Thu, 29 Sep 2016 15:11:27 +0200 Markus Armbruster wrote: > Alex Williamson writes: > > > On Tue, 13 Sep 2016 08:16:20 +0200 > > Markus Armbruster wrote: > > > >> Cc: Alex for device assignment expertise. > >> > >> Cao jin writes: > >> > >> > On 09/12/2016 09:29 PM, Markus Armbruster

Re: [Qemu-devel] [PATCH v2 1/5] msix_init: assert programming error

2016-09-29 Thread Markus Armbruster
Alex Williamson writes: > On Tue, 13 Sep 2016 08:16:20 +0200 > Markus Armbruster wrote: > >> Cc: Alex for device assignment expertise. >> >> Cao jin writes: >> >> > On 09/12/2016 09:29 PM, Markus Armbruster wrote: >> >> Cao jin writes: >> >> >> >>> The input parameters is used for creati

Re: [Qemu-devel] [PATCH v2 1/5] msix_init: assert programming error

2016-09-13 Thread Alex Williamson
On Tue, 13 Sep 2016 08:16:20 +0200 Markus Armbruster wrote: > Cc: Alex for device assignment expertise. > > Cao jin writes: > > > On 09/12/2016 09:29 PM, Markus Armbruster wrote: > >> Cao jin writes: > >> > >>> The input parameters is used for creating the msix capable device, so > >>> th

Re: [Qemu-devel] [PATCH v2 1/5] msix_init: assert programming error

2016-09-12 Thread Markus Armbruster
Cc: Alex for device assignment expertise. Cao jin writes: > On 09/12/2016 09:29 PM, Markus Armbruster wrote: >> Cao jin writes: >> >>> The input parameters is used for creating the msix capable device, so >>> they must obey the PCI spec, or else, it should be programming error. >> >> True when

Re: [Qemu-devel] [PATCH v2 1/5] msix_init: assert programming error

2016-09-12 Thread Cao jin
On 09/12/2016 09:29 PM, Markus Armbruster wrote: Cao jin writes: The input parameters is used for creating the msix capable device, so they must obey the PCI spec, or else, it should be programming error. True when the the parameters come from a device model attempting to define a PCI devi

Re: [Qemu-devel] [PATCH v2 1/5] msix_init: assert programming error

2016-09-12 Thread Markus Armbruster
Cao jin writes: > The input parameters is used for creating the msix capable device, so > they must obey the PCI spec, or else, it should be programming error. True when the the parameters come from a device model attempting to define a PCI device violating the spec. But what if the parameters

[Qemu-devel] [PATCH v2 1/5] msix_init: assert programming error

2016-08-23 Thread Cao jin
The input parameters is used for creating the msix capable device, so they must obey the PCI spec, or else, it should be programming error. CC: Markus Armbruster CC: Marcel Apfelbaum CC: Michael S. Tsirkin Signed-off-by: Cao jin --- hw/pci/msix.c | 6 ++ 1 file changed, 2 insertions(+), 4