Re: [Qemu-devel] [PATCH v2 1/4] tricore: remove no-op abs() calls

2015-03-18 Thread John Snow
On 03/18/2015 06:51 PM, Peter Maydell wrote: On 18 March 2015 at 22:43, John Snow wrote: Calling abs() on a uint32_t is a no-op, so remove it. clang 3.5.0 will not compile this if -Werror is set, throwing a -Wabsolute-value warning. Signed-off-by: John Snow This is probably the wrong fix

Re: [Qemu-devel] [PATCH v2 1/4] tricore: remove no-op abs() calls

2015-03-18 Thread Peter Maydell
On 18 March 2015 at 22:43, John Snow wrote: > Calling abs() on a uint32_t is a no-op, so remove it. > clang 3.5.0 will not compile this if -Werror is set, > throwing a -Wabsolute-value warning. > > Signed-off-by: John Snow This is probably the wrong fix (ie it silences the warning rather than fi

[Qemu-devel] [PATCH v2 1/4] tricore: remove no-op abs() calls

2015-03-18 Thread John Snow
Calling abs() on a uint32_t is a no-op, so remove it. clang 3.5.0 will not compile this if -Werror is set, throwing a -Wabsolute-value warning. Signed-off-by: John Snow --- target-tricore/op_helper.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/target-tricore/