Re: [Qemu-devel] [PATCH v2 1/4] sdcard: Update the SDState documentation

2018-05-14 Thread Philippe Mathieu-Daudé
On 05/14/2018 12:49 PM, Peter Maydell wrote: > On 10 May 2018 at 01:24, Philippe Mathieu-Daudé wrote: >> On 05/09/2018 12:42 PM, Alistair Francis wrote: >>> On Tue, May 8, 2018 at 11:01 PM, Philippe Mathieu-Daudé >>> wrote: Add more descriptive comments to keep a clear separation betwe

Re: [Qemu-devel] [PATCH v2 1/4] sdcard: Update the SDState documentation

2018-05-14 Thread Peter Maydell
On 10 May 2018 at 01:24, Philippe Mathieu-Daudé wrote: > On 05/09/2018 12:42 PM, Alistair Francis wrote: >> On Tue, May 8, 2018 at 11:01 PM, Philippe Mathieu-Daudé >> wrote: >>> Add more descriptive comments to keep a clear separation >>> between static property vs runtime changeable. >> Why do

Re: [Qemu-devel] [PATCH v2 1/4] sdcard: Update the SDState documentation

2018-05-09 Thread Philippe Mathieu-Daudé
On 05/09/2018 12:42 PM, Alistair Francis wrote: > On Tue, May 8, 2018 at 11:01 PM, Philippe Mathieu-Daudé > wrote: >> Add more descriptive comments to keep a clear separation >> between static property vs runtime changeable. >> >> Suggested-by: Peter Maydell >> Signed-off-by: Philippe Mathieu-Da

Re: [Qemu-devel] [PATCH v2 1/4] sdcard: Update the SDState documentation

2018-05-09 Thread Alistair Francis
On Tue, May 8, 2018 at 11:01 PM, Philippe Mathieu-Daudé wrote: > Add more descriptive comments to keep a clear separation > between static property vs runtime changeable. > > Suggested-by: Peter Maydell > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/sd/sd.c | 14 +- > 1 file cha

[Qemu-devel] [PATCH v2 1/4] sdcard: Update the SDState documentation

2018-05-08 Thread Philippe Mathieu-Daudé
Add more descriptive comments to keep a clear separation between static property vs runtime changeable. Suggested-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c ind