Re: [Qemu-devel] [PATCH v2 1/4] block/dirty-bitmaps: add inconsistent bit

2019-02-28 Thread Vladimir Sementsov-Ogievskiy
28.02.2019 16:44, Eric Blake wrote: > On 2/28/19 4:13 AM, Vladimir Sementsov-Ogievskiy wrote: > >> +++ b/qapi/block-core.json >> @@ -470,12 +470,16 @@ >>   # @persistent: true if the bitmap will eventually be flushed to >> persistent >>   #  storage (since 4.0)

Re: [Qemu-devel] [PATCH v2 1/4] block/dirty-bitmaps: add inconsistent bit

2019-02-28 Thread Eric Blake
On 2/28/19 4:13 AM, Vladimir Sementsov-Ogievskiy wrote: > +++ b/qapi/block-core.json > @@ -470,12 +470,16 @@ >   # @persistent: true if the bitmap will eventually be flushed to > persistent >   #  storage (since 4.0) >>> >>> so, bitmap can't be inconsistent and p

Re: [Qemu-devel] [PATCH v2 1/4] block/dirty-bitmaps: add inconsistent bit

2019-02-28 Thread Vladimir Sementsov-Ogievskiy
27.02.2019 21:45, John Snow wrote: > > > On 2/25/19 10:30 AM, Vladimir Sementsov-Ogievskiy wrote: >> 25.02.2019 17:18, Vladimir Sementsov-Ogievskiy wrote: >>> 23.02.2019 3:22, John Snow wrote: Add an inconsistent bit to dirty-bitmaps that allows us to report a bitmap as persistent

Re: [Qemu-devel] [PATCH v2 1/4] block/dirty-bitmaps: add inconsistent bit

2019-02-27 Thread John Snow
On 2/25/19 10:30 AM, Vladimir Sementsov-Ogievskiy wrote: > 25.02.2019 17:18, Vladimir Sementsov-Ogievskiy wrote: >> 23.02.2019 3:22, John Snow wrote: >>> Add an inconsistent bit to dirty-bitmaps that allows us to report a bitmap >>> as >>> persistent but potentially inconsistent, i.e. if we fin

Re: [Qemu-devel] [PATCH v2 1/4] block/dirty-bitmaps: add inconsistent bit

2019-02-25 Thread John Snow
On 2/25/19 9:18 AM, Vladimir Sementsov-Ogievskiy wrote: > 23.02.2019 3:22, John Snow wrote: >> Add an inconsistent bit to dirty-bitmaps that allows us to report a bitmap as >> persistent but potentially inconsistent, i.e. if we find bitmaps on a qcow2 >> that have been marked as "in use". >> >>

Re: [Qemu-devel] [PATCH v2 1/4] block/dirty-bitmaps: add inconsistent bit

2019-02-25 Thread Vladimir Sementsov-Ogievskiy
25.02.2019 17:18, Vladimir Sementsov-Ogievskiy wrote: > 23.02.2019 3:22, John Snow wrote: >> Add an inconsistent bit to dirty-bitmaps that allows us to report a bitmap as >> persistent but potentially inconsistent, i.e. if we find bitmaps on a qcow2 >> that have been marked as "in use". >> >> Signe

Re: [Qemu-devel] [PATCH v2 1/4] block/dirty-bitmaps: add inconsistent bit

2019-02-25 Thread Vladimir Sementsov-Ogievskiy
23.02.2019 3:22, John Snow wrote: > Add an inconsistent bit to dirty-bitmaps that allows us to report a bitmap as > persistent but potentially inconsistent, i.e. if we find bitmaps on a qcow2 > that have been marked as "in use". > > Signed-off-by: John Snow > --- > block/dirty-bitmap.c

Re: [Qemu-devel] [PATCH v2 1/4] block/dirty-bitmaps: add inconsistent bit

2019-02-25 Thread Eric Blake
On 2/22/19 6:22 PM, John Snow wrote: > Add an inconsistent bit to dirty-bitmaps that allows us to report a bitmap as > persistent but potentially inconsistent, i.e. if we find bitmaps on a qcow2 > that have been marked as "in use". > > Signed-off-by: John Snow > --- > block/dirty-bitmap.c

[Qemu-devel] [PATCH v2 1/4] block/dirty-bitmaps: add inconsistent bit

2019-02-22 Thread John Snow
Add an inconsistent bit to dirty-bitmaps that allows us to report a bitmap as persistent but potentially inconsistent, i.e. if we find bitmaps on a qcow2 that have been marked as "in use". Signed-off-by: John Snow --- block/dirty-bitmap.c | 19 +++ include/block/dirty-bit