Re: [Qemu-devel] [PATCH v2 1/4] Add i.MX FEC Ethernet driver

2013-05-07 Thread Peter Maydell
On 7 May 2013 01:39, Peter Crosthwaite wrote: > There may also be cases where machine model want to create a NIC > regardless of whether its used or not. Relevant for sysbus NICs as we > don't have the luxury of a PCI probe process so a generic guest (e.g. > a kernel and its pre-canned dtb) may as

Re: [Qemu-devel] [PATCH v2 1/4] Add i.MX FEC Ethernet driver

2013-05-06 Thread Peter Crosthwaite
Hi Peter, Michael, On Mon, May 6, 2013 at 10:01 PM, Peter Maydell wrote: > On 6 May 2013 10:24, Michael S. Tsirkin wrote: >> On Mon, May 06, 2013 at 10:08:42AM +0100, Peter Maydell wrote: >>> On 6 May 2013 09:51, Michael S. Tsirkin wrote: >>> > On Sun, May 05, 2013 at 11:00:24PM +0100, Peter Ma

Re: [Qemu-devel] [PATCH v2 1/4] Add i.MX FEC Ethernet driver

2013-05-06 Thread Peter Maydell
On 6 May 2013 10:24, Michael S. Tsirkin wrote: > On Mon, May 06, 2013 at 10:08:42AM +0100, Peter Maydell wrote: >> On 6 May 2013 09:51, Michael S. Tsirkin wrote: >> > On Sun, May 05, 2013 at 11:00:24PM +0100, Peter Maydell wrote: >> >> On 5 May 2013 22:15, Michael S. Tsirkin wrote: >> >> > On Su

Re: [Qemu-devel] [PATCH v2 1/4] Add i.MX FEC Ethernet driver

2013-05-06 Thread Michael S. Tsirkin
On Mon, May 06, 2013 at 10:08:42AM +0100, Peter Maydell wrote: > [cc'd Anthony since this has drifted into a more general topic] > > On 6 May 2013 09:51, Michael S. Tsirkin wrote: > > On Sun, May 05, 2013 at 11:00:24PM +0100, Peter Maydell wrote: > >> On 5 May 2013 22:15, Michael S. Tsirkin wrot

Re: [Qemu-devel] [PATCH v2 1/4] Add i.MX FEC Ethernet driver

2013-05-06 Thread Peter Maydell
[cc'd Anthony since this has drifted into a more general topic] On 6 May 2013 09:51, Michael S. Tsirkin wrote: > On Sun, May 05, 2013 at 11:00:24PM +0100, Peter Maydell wrote: >> On 5 May 2013 22:15, Michael S. Tsirkin wrote: >> > On Sun, May 05, 2013 at 07:01:34PM +0100, Peter Maydell wrote: >>

Re: [Qemu-devel] [PATCH v2 1/4] Add i.MX FEC Ethernet driver

2013-05-06 Thread Michael S. Tsirkin
On Sun, May 05, 2013 at 11:00:24PM +0100, Peter Maydell wrote: > On 5 May 2013 22:15, Michael S. Tsirkin wrote: > > On Sun, May 05, 2013 at 07:01:34PM +0100, Peter Maydell wrote: > >> Sorry, you can't say this until we've sorted out the mess > >> that is new-style networking options in a machine w

Re: [Qemu-devel] [PATCH v2 1/4] Add i.MX FEC Ethernet driver

2013-05-05 Thread Peter Maydell
On 5 May 2013 22:15, Michael S. Tsirkin wrote: > On Sun, May 05, 2013 at 07:01:34PM +0100, Peter Maydell wrote: >> Sorry, you can't say this until we've sorted out the mess >> that is new-style networking options in a machine which >> creates embedded network controllers. > What is missing exactl

Re: [Qemu-devel] [PATCH v2 1/4] Add i.MX FEC Ethernet driver

2013-05-05 Thread Michael S. Tsirkin
On Sun, May 05, 2013 at 07:01:34PM +0100, Peter Maydell wrote: > On 5 May 2013 18:49, Michael S. Tsirkin wrote: > > Let's not bother with legacy -net support > > for new devices. > > > > Anyone who wants it can create it with the new style > > -device flag. > > Sorry, you can't say this until we'

Re: [Qemu-devel] [PATCH v2 1/4] Add i.MX FEC Ethernet driver

2013-05-05 Thread Peter Maydell
On 5 May 2013 18:49, Michael S. Tsirkin wrote: > Let's not bother with legacy -net support > for new devices. > > Anyone who wants it can create it with the new style > -device flag. Sorry, you can't say this until we've sorted out the mess that is new-style networking options in a machine which

Re: [Qemu-devel] [PATCH v2 1/4] Add i.MX FEC Ethernet driver

2013-05-05 Thread Michael S. Tsirkin
On Sat, May 04, 2013 at 04:09:11PM +0200, Jean-Christophe DUBOIS wrote: > This is based on the mcf_fec.c FEC implementation for ColdFire. > > * a generic phy was added (borrowed from lan9118). > * The buffer management is also modified as buffers are > slightly different between cold

Re: [Qemu-devel] [PATCH v2 1/4] Add i.MX FEC Ethernet driver

2013-05-05 Thread Jean-Christophe DUBOIS
On 05/05/2013 03:31 PM, Andreas Färber wrote: Am 05.05.2013 15:14, schrieb Jean-Christophe DUBOIS: On 05/05/2013 05:11 AM, Peter Crosthwaite wrote: Hi JC, On Sun, May 5, 2013 at 12:09 AM, Jean-Christophe DUBOIS wrote: This is based on the mcf_fec.c FEC implementation for ColdFire. Note tha

Re: [Qemu-devel] [PATCH v2 1/4] Add i.MX FEC Ethernet driver

2013-05-05 Thread Andreas Färber
Am 05.05.2013 15:14, schrieb Jean-Christophe DUBOIS: > On 05/05/2013 05:11 AM, Peter Crosthwaite wrote: >> Hi JC, >> >> On Sun, May 5, 2013 at 12:09 AM, Jean-Christophe DUBOIS >> wrote: >>> This is based on the mcf_fec.c FEC implementation for ColdFire. Note that ColdFire is one of the least mai

Re: [Qemu-devel] [PATCH v2 1/4] Add i.MX FEC Ethernet driver

2013-05-05 Thread Jean-Christophe DUBOIS
On 05/05/2013 05:11 AM, Peter Crosthwaite wrote: Hi JC, On Sun, May 5, 2013 at 12:09 AM, Jean-Christophe DUBOIS wrote: This is based on the mcf_fec.c FEC implementation for ColdFire. * a generic phy was added (borrowed from lan9118). * The buffer management is also modified as buff

Re: [Qemu-devel] [PATCH v2 1/4] Add i.MX FEC Ethernet driver

2013-05-05 Thread Peter Maydell
On 5 May 2013 12:59, Peter Crosthwaite wrote: > While your here I have an on topic question, do we want creation > helpers like this? I notice that we progressively moving towards the > state where machine models talk to QOM directly without wrapper init > fns such as this.. Are functions like thi

Re: [Qemu-devel] [PATCH v2 1/4] Add i.MX FEC Ethernet driver

2013-05-05 Thread Peter Crosthwaite
Hi Andreas, On Sun, May 5, 2013 at 9:46 PM, Andreas Färber wrote: > Am 05.05.2013 05:11, schrieb Peter Crosthwaite: >> On Sun, May 5, 2013 at 12:09 AM, Jean-Christophe DUBOIS >> wrote: >>> +void imx_fec_create(int nic, const hwaddr base, qemu_irq irq) >> >> does this compile with Werror? I thoug

Re: [Qemu-devel] [PATCH v2 1/4] Add i.MX FEC Ethernet driver

2013-05-05 Thread Andreas Färber
Am 05.05.2013 05:11, schrieb Peter Crosthwaite: > On Sun, May 5, 2013 at 12:09 AM, Jean-Christophe DUBOIS > wrote: >> +void imx_fec_create(int nic, const hwaddr base, qemu_irq irq) > > does this compile with Werror? I thought there was a requirement that > all non-static functions must have a fn

Re: [Qemu-devel] [PATCH v2 1/4] Add i.MX FEC Ethernet driver

2013-05-04 Thread Peter Crosthwaite
Hi JC, On Sun, May 5, 2013 at 12:09 AM, Jean-Christophe DUBOIS wrote: > This is based on the mcf_fec.c FEC implementation for ColdFire. > > * a generic phy was added (borrowed from lan9118). > * The buffer management is also modified as buffers are > slightly different between coldf

[Qemu-devel] [PATCH v2 1/4] Add i.MX FEC Ethernet driver

2013-05-04 Thread Jean-Christophe DUBOIS
This is based on the mcf_fec.c FEC implementation for ColdFire. * a generic phy was added (borrowed from lan9118). * The buffer management is also modified as buffers are slightly different between coldfire and i.MX. Signed-off-by: Jean-Christophe DUBOIS --- default-configs/arm-so