Re: [Qemu-devel] [PATCH v2 1/3] util: add qemu_write_pidfile()

2018-09-11 Thread Paolo Bonzini
On 07/09/2018 16:03, Eric Blake wrote: > On 09/07/2018 07:13 AM, Marc-André Lureau wrote: >> There are variants of qemu_create_pidfile() in qemu-pr-helper and >> qemu-ga. Let's have a common implementation in libqemuutil. >> > > Unrelated to this patch, but a question that this raises: should > 'q

Re: [Qemu-devel] [PATCH v2 1/3] util: add qemu_write_pidfile()

2018-09-07 Thread Eric Blake
On 09/07/2018 07:13 AM, Marc-André Lureau wrote: There are variants of qemu_create_pidfile() in qemu-pr-helper and qemu-ga. Let's have a common implementation in libqemuutil. Unrelated to this patch, but a question that this raises: should 'qemu-nbd' also have a mode for creating a pid file,

[Qemu-devel] [PATCH v2 1/3] util: add qemu_write_pidfile()

2018-09-07 Thread Marc-André Lureau
There are variants of qemu_create_pidfile() in qemu-pr-helper and qemu-ga. Let's have a common implementation in libqemuutil. The code is initially based from pr-helper write_pidfile(), with various improvements and suggestions from Daniel Berrangé: QEMU will leave the pidfile existing on disk