Re: [Qemu-devel] [PATCH v2 1/3] qdev: using error_abort instead of using local_err

2014-08-20 Thread Gonglei (Arei)
> Subject: Re: [Qemu-devel] [PATCH v2 1/3] qdev: using error_abort instead of > using local_err > > On Thu, Aug 21, 2014 at 12:11 PM, wrote: > > From: Gonglei > > > > This error can not happen normally. If it happens indicates > > something very wrong,

Re: [Qemu-devel] [PATCH v2 1/3] qdev: using error_abort instead of using local_err

2014-08-20 Thread Peter Crosthwaite
On Thu, Aug 21, 2014 at 12:11 PM, wrote: > From: Gonglei > > This error can not happen normally. If it happens indicates > something very wrong, we should abort QEMU. moreover, The > user can only refer to /machine/peripheral, not > /machine/unattached. > > Signed-off-by: Gonglei Reviewed-by:

[Qemu-devel] [PATCH v2 1/3] qdev: using error_abort instead of using local_err

2014-08-20 Thread arei.gonglei
From: Gonglei This error can not happen normally. If it happens indicates something very wrong, we should abort QEMU. moreover, The user can only refer to /machine/peripheral, not /machine/unattached. Signed-off-by: Gonglei --- hw/core/qdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deleti