Re: [Qemu-devel] [PATCH v2 1/3] monitor: rename out_lock to mon_lock

2018-05-01 Thread Peter Xu
On Mon, Apr 30, 2018 at 10:56:49AM +0100, Stefan Hajnoczi wrote: > On Wed, Apr 18, 2018 at 05:02:37PM +0800, Peter Xu wrote: > > The out_lock was only protecting out buffers. In the future the monitor > > code will start to run in multiple threads. We turn it into a bigger > > lock to protect not

Re: [Qemu-devel] [PATCH v2 1/3] monitor: rename out_lock to mon_lock

2018-04-30 Thread Stefan Hajnoczi
On Wed, Apr 18, 2018 at 05:02:37PM +0800, Peter Xu wrote: > The out_lock was only protecting out buffers. In the future the monitor > code will start to run in multiple threads. We turn it into a bigger > lock to protect not only the out buffer but also all the rest. We split > this lock until n

[Qemu-devel] [PATCH v2 1/3] monitor: rename out_lock to mon_lock

2018-04-18 Thread Peter Xu
The out_lock was only protecting out buffers. In the future the monitor code will start to run in multiple threads. We turn it into a bigger lock to protect not only the out buffer but also all the rest. We split this lock until necessary. So far I don't see a reason to complicate lock usage fo