On Thu, Sep 13, 2012 at 07:52:35PM +0300, Orit Wasserman wrote:
> >> +for (e = res; e != NULL; e = e->ai_next) {
> >> +sock = inet_connect_addr(e, block, in_progress, errp);
> >> +if (in_progress && *in_progress) {
> >> +return sock;
> >
> > Doesn't this leak res?
>
On 09/13/2012 03:35 PM, Markus Armbruster wrote:
> Orit Wasserman writes:
>
>> From: Michael S. Tsirkin
>>
>> refactor address resolution code to fix nonblocking connect
>>
>> Signed-off-by: Michael S. Tsirkin
>> Signed-off-by: Amos Kong
>> Signed-off-by: Orit Wasserman
>> ---
>> qemu-socket
On 09/13/2012 04:14 PM, Markus Armbruster wrote:
> One more...
>
> Orit Wasserman writes:
>
> [...]
>> +static int inet_connect_addr(struct addrinfo *addr, bool block,
>> + bool *in_progress, Error **errp)
>
> Parameter errp is unused.
>
>> +{
>> +char uaddr[INE
On 09/13/2012 03:35 PM, Markus Armbruster wrote:
> Orit Wasserman writes:
>
>> From: Michael S. Tsirkin
>>
>> refactor address resolution code to fix nonblocking connect
>>
>> Signed-off-by: Michael S. Tsirkin
>> Signed-off-by: Amos Kong
>> Signed-off-by: Orit Wasserman
>> ---
>> qemu-socket
One more...
Orit Wasserman writes:
[...]
> +static int inet_connect_addr(struct addrinfo *addr, bool block,
> + bool *in_progress, Error **errp)
Parameter errp is unused.
> +{
> +char uaddr[INET6_ADDRSTRLEN + 1];
> +char uport[33];
> +int sock, rc;
> +
>
Orit Wasserman writes:
> From: Michael S. Tsirkin
>
> refactor address resolution code to fix nonblocking connect
>
> Signed-off-by: Michael S. Tsirkin
> Signed-off-by: Amos Kong
> Signed-off-by: Orit Wasserman
> ---
> qemu-sockets.c | 139
> +---
From: Michael S. Tsirkin
refactor address resolution code to fix nonblocking connect
Signed-off-by: Michael S. Tsirkin
Signed-off-by: Amos Kong
Signed-off-by: Orit Wasserman
---
qemu-sockets.c | 139 +---
1 files changed, 82 insertions(+),
