Re: [Qemu-devel] [PATCH v2 1/3] Add support for 64bit ARM system registers

2012-03-14 Thread Peter Maydell
On 14 March 2012 19:38, Michael Roth wrote: > On Wed, Mar 14, 2012 at 10:09:09PM +0300, Alexey Starikovskiy wrote: >> Do I need to do anything beside following or not? > > Not sure, ARM folks? > > My suggestion would be to lose the the catch-all -EINVAL error we > throw in machine.c:cpu_load() whe

Re: [Qemu-devel] [PATCH v2 1/3] Add support for 64bit ARM system registers

2012-03-14 Thread Michael Roth
On Wed, Mar 14, 2012 at 10:09:09PM +0300, Alexey Starikovskiy wrote: > Do I need to do anything beside following or not? Not sure, ARM folks? My suggestion would be to lose the the catch-all -EINVAL error we throw in machine.c:cpu_load() when version_id != CPU_SAVE_VERSION and only conditionally

Re: [Qemu-devel] [PATCH v2 1/3] Add support for 64bit ARM system registers

2012-03-14 Thread Alexey Starikovskiy
Do I need to do anything beside following or not? Thanks, Alex. On Wed, Mar 14, 2012 at 11:06 PM, Michael Roth wrote: >> > -#define CPU_SAVE_VERSION 6 >> > +#define CPU_SAVE_VERSION 7

Re: [Qemu-devel] [PATCH v2 1/3] Add support for 64bit ARM system registers

2012-03-14 Thread Michael Roth
On Wed, Mar 14, 2012 at 01:57:47PM -0500, Michael Roth wrote: > On Wed, Mar 14, 2012 at 05:00:02PM +0400, Alexey Starikovskiy wrote: > > Signed-off-by: Alexey Starikovskiy > > --- > > target-arm/cpu.h | 10 -- > > target-arm/helper.c | 14 +++--- > > target-arm/machine.c |

Re: [Qemu-devel] [PATCH v2 1/3] Add support for 64bit ARM system registers

2012-03-14 Thread Michael Roth
On Wed, Mar 14, 2012 at 05:00:02PM +0400, Alexey Starikovskiy wrote: > Signed-off-by: Alexey Starikovskiy > --- > target-arm/cpu.h | 10 -- > target-arm/helper.c | 14 +++--- > target-arm/machine.c | 16 ++-- > 3 files changed, 17 insertions(+), 23 deletions(

[Qemu-devel] [PATCH v2 1/3] Add support for 64bit ARM system registers

2012-03-14 Thread Alexey Starikovskiy
Signed-off-by: Alexey Starikovskiy --- target-arm/cpu.h | 10 -- target-arm/helper.c | 14 +++--- target-arm/machine.c | 16 ++-- 3 files changed, 17 insertions(+), 23 deletions(-) diff --git a/target-arm/cpu.h b/target-arm/cpu.h index 0d9b39c..0298a98 1006

[Qemu-devel] [PATCH v2 1/3] Add support for 64bit ARM system registers

2012-03-14 Thread Alexey Starikovskiy
Signed-off-by: Alexey Starikovskiy --- target-arm/cpu.h | 10 -- target-arm/helper.c | 14 +++--- target-arm/machine.c | 16 ++-- 3 files changed, 17 insertions(+), 23 deletions(-) diff --git a/target-arm/cpu.h b/target-arm/cpu.h index 0d9b39c..0298a98 1006

[Qemu-devel] [PATCH v2 1/3] Add support for 64bit ARM system registers

2012-03-14 Thread Alexey Starikovskiy
Signed-off-by: Alexey Starikovskiy --- target-arm/cpu.h | 10 -- target-arm/helper.c | 14 +++--- target-arm/machine.c | 16 ++-- 3 files changed, 17 insertions(+), 23 deletions(-) diff --git a/target-arm/cpu.h b/target-arm/cpu.h index 0d9b39c..0298a98 1006

[Qemu-devel] [PATCH v2 1/3] Add support for 64bit ARM system registers

2012-03-14 Thread Alexey Starikovskiy
Signed-off-by: Alexey Starikovskiy ---  target-arm/cpu.h |   10 --  target-arm/helper.c  |   14 +++---  target-arm/machine.c |   16 ++--  3 files changed, 17 insertions(+), 23 deletions(-) diff --git a/target-arm/cpu.h b/target-arm/cpu.h index 0d9b39c..0298a9