Re: [Qemu-devel] [PATCH v2 1/2] vl: don't use RUN_STATE_PRECONFIG as initial state

2018-06-05 Thread Eduardo Habkost
On Tue, Jun 05, 2018 at 04:25:17PM +0200, Igor Mammedov wrote: > On Tue, 5 Jun 2018 09:01:09 -0300 > Eduardo Habkost wrote: > > > On Tue, Jun 05, 2018 at 10:37:55AM +0200, Igor Mammedov wrote: > > > On Mon, 4 Jun 2018 21:56:47 -0300 > > > Eduardo Habkost wrote: > > > > On Mon, Jun 04, 2018 at

Re: [Qemu-devel] [PATCH v2 1/2] vl: don't use RUN_STATE_PRECONFIG as initial state

2018-06-05 Thread Igor Mammedov
On Tue, 5 Jun 2018 09:01:09 -0300 Eduardo Habkost wrote: > On Tue, Jun 05, 2018 at 10:37:55AM +0200, Igor Mammedov wrote: > > On Mon, 4 Jun 2018 21:56:47 -0300 > > Eduardo Habkost wrote: > > > On Mon, Jun 04, 2018 at 04:21:47PM +0200, Michal Privoznik wrote: > > > [...] > > > > > @@ -3572,7

Re: [Qemu-devel] [PATCH v2 1/2] vl: don't use RUN_STATE_PRECONFIG as initial state

2018-06-05 Thread Daniel P . Berrangé
On Mon, Jun 04, 2018 at 01:03:44PM +0100, Daniel P. Berrangé wrote: > diff --git a/vl.c b/vl.c > index 06031715ac..30d0e985f0 100644 > --- a/vl.c > +++ b/vl.c > @@ -561,7 +561,7 @@ static int default_driver_check(void *opaque, QemuOpts > *opts, Error **errp) > /**

Re: [Qemu-devel] [PATCH v2 1/2] vl: don't use RUN_STATE_PRECONFIG as initial state

2018-06-05 Thread Daniel P . Berrangé
On Mon, Jun 04, 2018 at 04:21:47PM +0200, Michal Privoznik wrote: > On 06/04/2018 02:03 PM, Daniel P. Berrangé wrote: > > @@ -3572,7 +3570,12 @@ int main(int argc, char **argv, char **envp) > > } > > break; > > case QEMU_OPTION_preconfig: > > -

Re: [Qemu-devel] [PATCH v2 1/2] vl: don't use RUN_STATE_PRECONFIG as initial state

2018-06-05 Thread Eduardo Habkost
On Tue, Jun 05, 2018 at 10:37:55AM +0200, Igor Mammedov wrote: > On Mon, 4 Jun 2018 21:56:47 -0300 > Eduardo Habkost wrote: > > On Mon, Jun 04, 2018 at 04:21:47PM +0200, Michal Privoznik wrote: > > [...] > > > > @@ -3572,7 +3570,12 @@ int main(int argc, char **argv, char **envp) > > > >

Re: [Qemu-devel] [PATCH v2 1/2] vl: don't use RUN_STATE_PRECONFIG as initial state

2018-06-05 Thread Igor Mammedov
On Mon, 4 Jun 2018 21:56:47 -0300 Eduardo Habkost wrote: > On Mon, Jun 04, 2018 at 04:21:47PM +0200, Michal Privoznik wrote: > [...] > > > @@ -3572,7 +3570,12 @@ int main(int argc, char **argv, char **envp) > > > } > > > break; > > > case QEMU_OPTION

Re: [Qemu-devel] [PATCH v2 1/2] vl: don't use RUN_STATE_PRECONFIG as initial state

2018-06-05 Thread Igor Mammedov
On Mon, 4 Jun 2018 21:35:46 -0300 Eduardo Habkost wrote: > On Mon, Jun 04, 2018 at 07:37:15PM +0200, Igor Mammedov wrote: > > On Mon, 4 Jun 2018 17:11:57 +0100 > > Daniel P. Berrangé wrote: > > > > > On Mon, Jun 04, 2018 at 05:40:32PM +0200, Igor Mammedov wrote: > > > > On Mon, 4 Jun 2018

Re: [Qemu-devel] [PATCH v2 1/2] vl: don't use RUN_STATE_PRECONFIG as initial state

2018-06-04 Thread Eduardo Habkost
On Mon, Jun 04, 2018 at 04:21:47PM +0200, Michal Privoznik wrote: [...] > > @@ -3572,7 +3570,12 @@ int main(int argc, char **argv, char **envp) > > } > > break; > > case QEMU_OPTION_preconfig: > > -preconfig_exit_requested = false; > >

Re: [Qemu-devel] [PATCH v2 1/2] vl: don't use RUN_STATE_PRECONFIG as initial state

2018-06-04 Thread Eduardo Habkost
On Mon, Jun 04, 2018 at 07:37:15PM +0200, Igor Mammedov wrote: > On Mon, 4 Jun 2018 17:11:57 +0100 > Daniel P. Berrangé wrote: > > > On Mon, Jun 04, 2018 at 05:40:32PM +0200, Igor Mammedov wrote: > > > On Mon, 4 Jun 2018 13:03:44 +0100 > > > Daniel P. Berrangé wrote: > > > > > > > The RUN_ST

Re: [Qemu-devel] [PATCH v2 1/2] vl: don't use RUN_STATE_PRECONFIG as initial state

2018-06-04 Thread Igor Mammedov
On Mon, 4 Jun 2018 17:11:57 +0100 Daniel P. Berrangé wrote: > On Mon, Jun 04, 2018 at 05:40:32PM +0200, Igor Mammedov wrote: > > On Mon, 4 Jun 2018 13:03:44 +0100 > > Daniel P. Berrangé wrote: > > > > > The RUN_STATE_PRECONFIG state is not supposed to be reachable unless the > > > --preconfi

Re: [Qemu-devel] [PATCH v2 1/2] vl: don't use RUN_STATE_PRECONFIG as initial state

2018-06-04 Thread Daniel P . Berrangé
On Mon, Jun 04, 2018 at 05:40:32PM +0200, Igor Mammedov wrote: > On Mon, 4 Jun 2018 13:03:44 +0100 > Daniel P. Berrangé wrote: > > > The RUN_STATE_PRECONFIG state is not supposed to be reachable unless the > > --preconfig argument is given to QEMU, but when it was introduced in: > > > > commi

Re: [Qemu-devel] [PATCH v2 1/2] vl: don't use RUN_STATE_PRECONFIG as initial state

2018-06-04 Thread Igor Mammedov
On Mon, 4 Jun 2018 13:03:44 +0100 Daniel P. Berrangé wrote: > The RUN_STATE_PRECONFIG state is not supposed to be reachable unless the > --preconfig argument is given to QEMU, but when it was introduced in: > > commit 047f7038f586d2150f16c6d9ba9cfd0479f0f6ac > Author: Igor Mammedov > Dat

Re: [Qemu-devel] [PATCH v2 1/2] vl: don't use RUN_STATE_PRECONFIG as initial state

2018-06-04 Thread Michal Privoznik
On 06/04/2018 02:03 PM, Daniel P. Berrangé wrote: > The RUN_STATE_PRECONFIG state is not supposed to be reachable unless the > --preconfig argument is given to QEMU, but when it was introduced in: > > commit 047f7038f586d2150f16c6d9ba9cfd0479f0f6ac > Author: Igor Mammedov > Date: Fri May

[Qemu-devel] [PATCH v2 1/2] vl: don't use RUN_STATE_PRECONFIG as initial state

2018-06-04 Thread Daniel P . Berrangé
The RUN_STATE_PRECONFIG state is not supposed to be reachable unless the --preconfig argument is given to QEMU, but when it was introduced in: commit 047f7038f586d2150f16c6d9ba9cfd0479f0f6ac Author: Igor Mammedov Date: Fri May 11 19:24:43 2018 +0200 cli: add --preconfig option ...th