Re: [Qemu-devel] [PATCH v2 1/2] virtio: rename virtqueue_discard to virtqueue_unpop

2016-11-04 Thread Cornelia Huck
On Fri, 4 Nov 2016 07:19:16 +0100 Ladi Prosek wrote: > On Fri, Nov 4, 2016 at 3:42 AM, Alexey Kardashevskiy wrote: > > On 03/11/16 19:55, Ladi Prosek wrote: > >> The function undoes the effect of virtqueue_pop and doesn't do anything > >> destructive or irreversible so virtqueue_unpop is a more

Re: [Qemu-devel] [PATCH v2 1/2] virtio: rename virtqueue_discard to virtqueue_unpop

2016-11-03 Thread Ladi Prosek
On Fri, Nov 4, 2016 at 3:42 AM, Alexey Kardashevskiy wrote: > On 03/11/16 19:55, Ladi Prosek wrote: >> The function undoes the effect of virtqueue_pop and doesn't do anything >> destructive or irreversible so virtqueue_unpop is a more fitting name. > > virtqueue_undo_pop() is even better, it was s

Re: [Qemu-devel] [PATCH v2 1/2] virtio: rename virtqueue_discard to virtqueue_unpop

2016-11-03 Thread Alexey Kardashevskiy
On 03/11/16 19:55, Ladi Prosek wrote: > The function undoes the effect of virtqueue_pop and doesn't do anything > destructive or irreversible so virtqueue_unpop is a more fitting name. virtqueue_undo_pop() is even better, it was suggested by native english speaker (i.e. not myself) :) > > Sign

[Qemu-devel] [PATCH v2 1/2] virtio: rename virtqueue_discard to virtqueue_unpop

2016-11-03 Thread Ladi Prosek
The function undoes the effect of virtqueue_pop and doesn't do anything destructive or irreversible so virtqueue_unpop is a more fitting name. Signed-off-by: Ladi Prosek --- hw/net/virtio-net.c| 2 +- hw/virtio/virtio-balloon.c | 2 +- hw/virtio/virtio.c | 8 include/hw/