Re: [Qemu-devel] [PATCH v2 1/2] qga: flush explicitly when needed

2015-11-24 Thread Eric Blake
On 11/24/2015 03:19 PM, Michael Roth wrote: >> Hmm. This always attempts fseek() on the first write() to a file, even >> if the file is not also open for read. While guest-file-open is most >> likely used on regular files (and therefore seekable), I'm worried that >> we might have a client that

Re: [Qemu-devel] [PATCH v2 1/2] qga: flush explicitly when needed

2015-11-24 Thread Michael Roth
Quoting Eric Blake (2015-11-24 14:56:15) > On 11/24/2015 11:04 AM, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > According to the specification: > > http://pubs.opengroup.org/onlinepubs/9699919799/functions/fopen.html > > > > "the application shall ensure that output is

Re: [Qemu-devel] [PATCH v2 1/2] qga: flush explicitly when needed

2015-11-24 Thread Eric Blake
On 11/24/2015 11:04 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > According to the specification: > http://pubs.opengroup.org/onlinepubs/9699919799/functions/fopen.html > > "the application shall ensure that output is not directly followed by > input without an intervening

[Qemu-devel] [PATCH v2 1/2] qga: flush explicitly when needed

2015-11-24 Thread marcandre . lureau
From: Marc-André Lureau According to the specification: http://pubs.opengroup.org/onlinepubs/9699919799/functions/fopen.html "the application shall ensure that output is not directly followed by input without an intervening call to fflush() or to a file positioning function (fseek(), fsetpos(),