Re: [Qemu-devel] [PATCH v2 1/2] Make default boot order machine specific

2012-10-25 Thread Alexander Graf
On 25.10.2012, at 22:50, Peter Maydell wrote: > On 25 October 2012 21:18, Anthony Liguori wrote: >> The other approach to this would be: >> >> static QEMUMachine pseries_machine = { >>.no_boot_order = 1, >> }; >> >> Which I think is what Peter is suggesting. I'm not a huge fan of this >>

Re: [Qemu-devel] [PATCH v2 1/2] Make default boot order machine specific

2012-10-25 Thread Peter Maydell
On 25 October 2012 21:18, Anthony Liguori wrote: > The other approach to this would be: > > static QEMUMachine pseries_machine = { > .no_boot_order = 1, > }; > > Which I think is what Peter is suggesting. I'm not a huge fan of this > because it's backwards logic but we already do this for a b

Re: [Qemu-devel] [PATCH v2 1/2] Make default boot order machine specific

2012-10-25 Thread Anthony Liguori
Peter Maydell writes: > On 25 October 2012 15:38, Avik Sil wrote: >> @@ -171,6 +171,7 @@ static QEMUMachine clipper_machine = { >> .init = clipper_init, >> .max_cpus = 4, >> .is_default = 1, >> +.default_machine_opts = DEFAULT_BOOT_ORDER, >> }; > >> @@ -86,6 +86,7 @@ static Q

Re: [Qemu-devel] [PATCH v2 1/2] Make default boot order machine specific

2012-10-25 Thread Peter Maydell
On 25 October 2012 15:38, Avik Sil wrote: > @@ -171,6 +171,7 @@ static QEMUMachine clipper_machine = { > .init = clipper_init, > .max_cpus = 4, > .is_default = 1, > +.default_machine_opts = DEFAULT_BOOT_ORDER, > }; > @@ -86,6 +86,7 @@ static QEMUMachine an5206_machine = { >

[Qemu-devel] [PATCH v2 1/2] Make default boot order machine specific

2012-10-25 Thread Avik Sil
This patch makes default boot order machine specific instead of set globally. The default boot order can be set per machine in QEMUMachine default_machine_opts, or by the command line using -machine ,boot=, or by standard -boot option. This allows a machine to receive a NULL boot order when -boot i