Re: [Qemu-devel] [PATCH v2 1/1] quorum: Change vote rules for 64 bits hash

2016-02-22 Thread Changlong Xie
On 02/22/2016 06:34 PM, Kevin Wolf wrote: Am 22.02.2016 um 10:02 hat Dr. David Alan Gilbert geschrieben: * Changlong Xie (xiecl.f...@cn.fujitsu.com) wrote: On 02/20/2016 10:28 PM, Max Reitz wrote: On 19.02.2016 12:24, Alberto Garcia wrote: On Fri 19 Feb 2016 09:26:53 AM CET, Wen Congyang wro

Re: [Qemu-devel] [PATCH v2 1/1] quorum: Change vote rules for 64 bits hash

2016-02-22 Thread Eric Blake
On 02/22/2016 06:31 AM, Alberto Garcia wrote: > The way I see it is that if we have, say, 5 drives with a threshold of 3 > and flushing fails in one of them Quorum should report the error (with > QUORUM_REPORT_BAD probably, or maybe a new event) but succeed, because > we have at least 3 images tha

Re: [Qemu-devel] [PATCH v2 1/1] quorum: Change vote rules for 64 bits hash

2016-02-22 Thread Alberto Garcia
On Mon 22 Feb 2016 02:31:30 PM CET, Alberto Garcia wrote: >> Anyway, regardless of that, if we do take the threshold into account, >> we should not use the exact error value for voting but just whether >> an error occurred or not. If all but one children fail to flush (all >> for different reasons)

Re: [Qemu-devel] [PATCH v2 1/1] quorum: Change vote rules for 64 bits hash

2016-02-22 Thread Alberto Garcia
On Sat 20 Feb 2016 03:28:03 PM CET, Max Reitz wrote: >> That said, I'm not very convinced of the current logics of the Quorum >> flush code either, so it's not even a problem with your patch... it >> seems to me that the code should follow the same logics as in the >> read/write case: if the numb

Re: [Qemu-devel] [PATCH v2 1/1] quorum: Change vote rules for 64 bits hash

2016-02-22 Thread Dr. David Alan Gilbert
* Kevin Wolf (kw...@redhat.com) wrote: > Am 22.02.2016 um 10:02 hat Dr. David Alan Gilbert geschrieben: > > * Changlong Xie (xiecl.f...@cn.fujitsu.com) wrote: > > > On 02/20/2016 10:28 PM, Max Reitz wrote: > > > >On 19.02.2016 12:24, Alberto Garcia wrote: > > > >>On Fri 19 Feb 2016 09:26:53 AM CET,

Re: [Qemu-devel] [PATCH v2 1/1] quorum: Change vote rules for 64 bits hash

2016-02-22 Thread Kevin Wolf
Am 22.02.2016 um 10:02 hat Dr. David Alan Gilbert geschrieben: > * Changlong Xie (xiecl.f...@cn.fujitsu.com) wrote: > > On 02/20/2016 10:28 PM, Max Reitz wrote: > > >On 19.02.2016 12:24, Alberto Garcia wrote: > > >>On Fri 19 Feb 2016 09:26:53 AM CET, Wen Congyang > > >>wrote: > > >> > > >If q

Re: [Qemu-devel] [PATCH v2 1/1] quorum: Change vote rules for 64 bits hash

2016-02-22 Thread Dr. David Alan Gilbert
* Changlong Xie (xiecl.f...@cn.fujitsu.com) wrote: > On 02/22/2016 05:02 PM, Dr. David Alan Gilbert wrote: > >* Changlong Xie (xiecl.f...@cn.fujitsu.com) wrote: > >>On 02/20/2016 10:28 PM, Max Reitz wrote: > >>>On 19.02.2016 12:24, Alberto Garcia wrote: > On Fri 19 Feb 2016 09:26:53 AM CET, Wen

Re: [Qemu-devel] [PATCH v2 1/1] quorum: Change vote rules for 64 bits hash

2016-02-22 Thread Changlong Xie
On 02/22/2016 05:02 PM, Dr. David Alan Gilbert wrote: * Changlong Xie (xiecl.f...@cn.fujitsu.com) wrote: On 02/20/2016 10:28 PM, Max Reitz wrote: On 19.02.2016 12:24, Alberto Garcia wrote: On Fri 19 Feb 2016 09:26:53 AM CET, Wen Congyang wrote: If quorum has two children(A, B). A do flush s

Re: [Qemu-devel] [PATCH v2 1/1] quorum: Change vote rules for 64 bits hash

2016-02-22 Thread Dr. David Alan Gilbert
* Changlong Xie (xiecl.f...@cn.fujitsu.com) wrote: > On 02/20/2016 10:28 PM, Max Reitz wrote: > >On 19.02.2016 12:24, Alberto Garcia wrote: > >>On Fri 19 Feb 2016 09:26:53 AM CET, Wen Congyang > >>wrote: > >> > >If quorum has two children(A, B). A do flush sucessfully, but B > >flush fail

Re: [Qemu-devel] [PATCH v2 1/1] quorum: Change vote rules for 64 bits hash

2016-02-21 Thread Changlong Xie
On 02/20/2016 10:28 PM, Max Reitz wrote: On 19.02.2016 12:24, Alberto Garcia wrote: On Fri 19 Feb 2016 09:26:53 AM CET, Wen Congyang wrote: If quorum has two children(A, B). A do flush sucessfully, but B flush failed. We MUST choice A as winner rather than just pick anyone of them. Otherwise

Re: [Qemu-devel] [PATCH v2 1/1] quorum: Change vote rules for 64 bits hash

2016-02-20 Thread Max Reitz
On 19.02.2016 12:24, Alberto Garcia wrote: > On Fri 19 Feb 2016 09:26:53 AM CET, Wen Congyang wrote: > If quorum has two children(A, B). A do flush sucessfully, but B flush failed. We MUST choice A as winner rather than just pick anyone of them. Otherwise the filesystem of guest w

Re: [Qemu-devel] [PATCH v2 1/1] quorum: Change vote rules for 64 bits hash

2016-02-19 Thread Alberto Garcia
On Fri 19 Feb 2016 09:26:53 AM CET, Wen Congyang wrote: >>> If quorum has two children(A, B). A do flush sucessfully, but B >>> flush failed. We MUST choice A as winner rather than just pick >>> anyone of them. Otherwise the filesystem of guest will become >>> read-only with following errors: >>

Re: [Qemu-devel] [PATCH v2 1/1] quorum: Change vote rules for 64 bits hash

2016-02-19 Thread Wen Congyang
On 02/18/2016 11:16 PM, Alberto Garcia wrote: > On Tue 16 Feb 2016 03:15:44 AM CET, Changlong Xie > wrote: >> If quorum has two children(A, B). A do flush sucessfully, but B flush >> failed. We MUST choice A as winner rather than just pick anyone of >> them. Otherwise the filesystem of guest wil

Re: [Qemu-devel] [PATCH v2 1/1] quorum: Change vote rules for 64 bits hash

2016-02-18 Thread Alberto Garcia
On Tue 16 Feb 2016 03:15:44 AM CET, Changlong Xie wrote: > If quorum has two children(A, B). A do flush sucessfully, but B flush > failed. We MUST choice A as winner rather than just pick anyone of > them. Otherwise the filesystem of guest will become read-only with > following errors: > > end_r

Re: [Qemu-devel] [PATCH v2 1/1] quorum: Change vote rules for 64 bits hash

2016-02-18 Thread Dr. David Alan Gilbert
* Changlong Xie (xiecl.f...@cn.fujitsu.com) wrote: > If quorum has two children(A, B). A do flush sucessfully, but B flush failed. > We MUST choice A as winner rather than just pick anyone of them. Otherwise > the filesystem of guest will become read-only with following errors: > > end_request: I/

[Qemu-devel] [PATCH v2 1/1] quorum: Change vote rules for 64 bits hash

2016-02-15 Thread Changlong Xie
If quorum has two children(A, B). A do flush sucessfully, but B flush failed. We MUST choice A as winner rather than just pick anyone of them. Otherwise the filesystem of guest will become read-only with following errors: end_request: I/O error, dev vda, sector 11159960 Aborting journal on device