Re: [Qemu-devel] [PATCH v2 1/1] qom/object: Don't poll cast cache for NULL objects

2013-05-22 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH v2 1/1] qom/object: Don't poll cast cache for NULL objects

2013-05-21 Thread Edgar E. Iglesias
On Wed, May 22, 2013 at 11:19:16AM +1000, peter.crosthwa...@xilinx.com wrote: > From: Peter Crosthwaite > > object_dynamic_cast_assert used to be tolerant of NULL objects and not > assert. It's clear from the implementation that this is the expected > behavior. > > The preceding check of the cas

Re: [Qemu-devel] [PATCH v2 1/1] qom/object: Don't poll cast cache for NULL objects

2013-05-21 Thread Paolo Bonzini
- Messaggio originale - > Da: "peter crosthwaite" > A: qemu-devel@nongnu.org > Cc: aligu...@us.ibm.com, "edgar iglesias" , > pbonz...@redhat.com, afaer...@suse.de > Inviato: Mercoledì, 22 maggio 2013 3:19:16 > Oggetto: [PATCH v2 1/1] qom/object: Don't poll cast cache for NULL objects >

[Qemu-devel] [PATCH v2 1/1] qom/object: Don't poll cast cache for NULL objects

2013-05-21 Thread peter . crosthwaite
From: Peter Crosthwaite object_dynamic_cast_assert used to be tolerant of NULL objects and not assert. It's clear from the implementation that this is the expected behavior. The preceding check of the cast cache dereferences obj however causing a segfault. Fix by conditionalizing the cast cache