Re: [Qemu-devel] [PATCH v2 1/1] qga-win: fix installation on localized windows

2017-06-20 Thread Sameeh Jubran
This patch have been waiting too long for a review, Can someone please review it!! On Thu, Jun 1, 2017 at 3:07 PM, Sameeh Jubran wrote: > Can someone review this patch please? > > On Thu, May 25, 2017 at 2:06 PM, Sameeh Jubran wrote: > >> Ping >> >> On Sun, May 14, 2017 at 3:53 PM, Sameeh Jubra

Re: [Qemu-devel] [PATCH v2 1/1] qga-win: fix installation on localized windows

2017-06-01 Thread Sameeh Jubran
Can someone review this patch please? On Thu, May 25, 2017 at 2:06 PM, Sameeh Jubran wrote: > Ping > > On Sun, May 14, 2017 at 3:53 PM, Sameeh Jubran wrote: > >> Reviewed-by: Sameeh Jubran >> >> On Thu, Apr 27, 2017 at 4:21 PM, Daniel Rempel wrote: >> >>> Bug: https://bugzilla.redhat.com/show

Re: [Qemu-devel] [PATCH v2 1/1] qga-win: fix installation on localized windows

2017-05-25 Thread Sameeh Jubran
Ping On Sun, May 14, 2017 at 3:53 PM, Sameeh Jubran wrote: > Reviewed-by: Sameeh Jubran > > On Thu, Apr 27, 2017 at 4:21 PM, Daniel Rempel wrote: > >> Bug: https://bugzilla.redhat.com/show_bug.cgi?id=1357789 >> Replace hardcoded user and group names ("Administrators", "SYSTEM") with >> the one

Re: [Qemu-devel] [PATCH v2 1/1] qga-win: fix installation on localized windows

2017-05-14 Thread Sameeh Jubran
Reviewed-by: Sameeh Jubran On Thu, Apr 27, 2017 at 4:21 PM, Daniel Rempel wrote: > Bug: https://bugzilla.redhat.com/show_bug.cgi?id=1357789 > Replace hardcoded user and group names ("Administrators", "SYSTEM") with > the ones acquired from system. Windows uses localized strings for these > name

[Qemu-devel] [PATCH v2 1/1] qga-win: fix installation on localized windows

2017-04-27 Thread Daniel Rempel
Bug: https://bugzilla.redhat.com/show_bug.cgi?id=1357789 Replace hardcoded user and group names ("Administrators", "SYSTEM") with the ones acquired from system. Windows uses localized strings for these names and it may cause the installation to fail. Windows has Well-known SIDs for "Administrator