On 05/12/2014 12:45, Jiri Slaby wrote:
> On 12/05/2014, 11:35 AM, Paolo Bonzini wrote:
>> Hi Jirka,
>>
>> because this is supposed to be a poster of good QEMU practices, the
>> review is going to be a bit picky. Most comments are trivial to apply.
>
> Hi, OK :).
>
>>> --- /dev/null
>>> +++ b/h
On 12/05/2014, 11:35 AM, Paolo Bonzini wrote:
> Hi Jirka,
>
> because this is supposed to be a poster of good QEMU practices, the
> review is going to be a bit picky. Most comments are trivial to apply.
Hi, OK :).
>> --- /dev/null
>> +++ b/hw/misc/edu.c
>> @@ -0,0 +1,351 @@
...
>> +static void
Hi Jirka,
because this is supposed to be a poster of good QEMU practices, the
review is going to be a bit picky. Most comments are trivial to apply.
>
> +0x20 (RO) : status register, bitwise OR
> + 0x01 -- computing factorial
> +
Perhaps bit 0 can be read-only, while bit 1 is set/clear
I am using qemu for teaching the Linux kernel at our university. I
wrote a simple PCI device that can answer to writes/reads, generate
interrupts and perform DMA. As I am dragging it locally over 2 years,
I am sending it to you now.
Signed-off-by: Jiri Slaby
Cc: Paolo Bonzini
---
MAINTAINERS
On 12/05/2014, 10:52 AM, Jiri Slaby wrote:
> hw/misc/edu.c | 351
>
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -593,6 +593,11 @@ F: hw/net/opencores_eth.c
>
> Devices
> ---
> +EDU
> +M: Jiri Slaby
> +S: Maintained
> +F: hw/pci
