Re: [Qemu-devel] [PATCH v2 1/1] char/serial: Fix emptyness handling

2014-03-17 Thread Peter Crosthwaite
On Tue, Mar 18, 2014 at 5:29 AM, Don Slutz wrote: > On 03/16/14 22:21, Peter Crosthwaite wrote: >> >> On Thu, Feb 27, 2014 at 12:48 PM, Don Slutz wrote: >>> >>> The commit 88c1ee73d3231c74ff90bcfc084a7589670ec244 >>> char/serial: Fix emptyness check >>> >>> Still causes extra NULL byte(s) to be s

Re: [Qemu-devel] [PATCH v2 1/1] char/serial: Fix emptyness handling

2014-03-17 Thread Don Slutz
On 03/16/14 22:21, Peter Crosthwaite wrote: On Thu, Feb 27, 2014 at 12:48 PM, Don Slutz wrote: The commit 88c1ee73d3231c74ff90bcfc084a7589670ec244 char/serial: Fix emptyness check Still causes extra NULL byte(s) to be sent. So if the fifo is empty, do not send an extra NULL byte. Do full stat

Re: [Qemu-devel] [PATCH v2 1/1] char/serial: Fix emptyness handling

2014-03-16 Thread Peter Crosthwaite
On Thu, Feb 27, 2014 at 12:48 PM, Don Slutz wrote: > The commit 88c1ee73d3231c74ff90bcfc084a7589670ec244 > char/serial: Fix emptyness check > > Still causes extra NULL byte(s) to be sent. > > So if the fifo is empty, do not send an extra NULL byte. > Do full state change on fifo8_is_empty. > > Sig

Re: [Qemu-devel] [PATCH v2 1/1] char/serial: Fix emptyness handling

2014-03-12 Thread Don Slutz
Ping. On 02/26/14 21:48, Don Slutz wrote: The commit 88c1ee73d3231c74ff90bcfc084a7589670ec244 char/serial: Fix emptyness check Still causes extra NULL byte(s) to be sent. So if the fifo is empty, do not send an extra NULL byte. Do full state change on fifo8_is_empty. Signed-off-by: Don Slutz

[Qemu-devel] [PATCH v2 1/1] char/serial: Fix emptyness handling

2014-02-26 Thread Don Slutz
The commit 88c1ee73d3231c74ff90bcfc084a7589670ec244 char/serial: Fix emptyness check Still causes extra NULL byte(s) to be sent. So if the fifo is empty, do not send an extra NULL byte. Do full state change on fifo8_is_empty. Signed-off-by: Don Slutz --- v1 to v2: Do all the state changes that