Re: [Qemu-devel] [PATCH v2 1/1] atapi: abort transfers with 0 byte limits

2015-09-14 Thread John Snow
On 09/10/2015 11:11 PM, Fam Zheng wrote: > On Thu, 09/10 19:20, John Snow wrote: >> >> +/* Nondata commands permit the byte_count_limit to be 0. >> + * If this is a data-transferring PIO command and BCL is 0, >> + * we abort at the /ATA/ level, not the ATAPI level. >> + * See AT

Re: [Qemu-devel] [PATCH v2 1/1] atapi: abort transfers with 0 byte limits

2015-09-10 Thread Fam Zheng
On Thu, 09/10 19:20, John Snow wrote: > > +/* Nondata commands permit the byte_count_limit to be 0. > + * If this is a data-transferring PIO command and BCL is 0, > + * we abort at the /ATA/ level, not the ATAPI level. > + * See ATA8 ACS3 section 7.17.6.49 and 7.21.5 */ > +if

[Qemu-devel] [PATCH v2 1/1] atapi: abort transfers with 0 byte limits

2015-09-10 Thread John Snow
We're supposed to abort on transfers like this, unless we fill Word 125 of our IDENTIFY data with a default transfer size, which we don't currently do. This is an ATA error, not a SCSI/ATAPI one. See ATA8-ACS3 sections 7.17.6.49 or 7.21.5. If we don't do this, QEMU will loop forever trying to tra