Re: [Qemu-devel] [PATCH v2 09/10] qmp.py: Avoid overriding a builtin object

2017-07-26 Thread Eduardo Habkost
On Wed, Jul 26, 2017 at 06:46:30AM +0200, Lukáš Doktor wrote: > Dne 25.7.2017 v 21:34 Eduardo Habkost napsal(a): > > On Tue, Jul 25, 2017 at 05:09:50PM +0200, Lukáš Doktor wrote: > >> The "id" is a builtin method to get object's identity and should not be > >> overridden. This might bring some issu

Re: [Qemu-devel] [PATCH v2 09/10] qmp.py: Avoid overriding a builtin object

2017-07-25 Thread Lukáš Doktor
Dne 25.7.2017 v 21:34 Eduardo Habkost napsal(a): > On Tue, Jul 25, 2017 at 05:09:50PM +0200, Lukáš Doktor wrote: >> The "id" is a builtin method to get object's identity and should not be >> overridden. This might bring some issues in case someone was directly >> calling "cmd(..., id=id)" but I hav

Re: [Qemu-devel] [PATCH v2 09/10] qmp.py: Avoid overriding a builtin object

2017-07-25 Thread Eduardo Habkost
On Tue, Jul 25, 2017 at 05:09:50PM +0200, Lukáš Doktor wrote: > The "id" is a builtin method to get object's identity and should not be > overridden. This might bring some issues in case someone was directly > calling "cmd(..., id=id)" but I haven't found such usage on brief search > for "cmd\(.*id

[Qemu-devel] [PATCH v2 09/10] qmp.py: Avoid overriding a builtin object

2017-07-25 Thread Lukáš Doktor
The "id" is a builtin method to get object's identity and should not be overridden. This might bring some issues in case someone was directly calling "cmd(..., id=id)" but I haven't found such usage on brief search for "cmd\(.*id=". Signed-off-by: Lukáš Doktor --- scripts/qmp/qmp.py | 8