Re: [Qemu-devel] [PATCH v2 08/27] qom: fix off-by-one

2012-02-07 Thread Paolo Bonzini
On 02/06/2012 03:19 PM, Anthony Liguori wrote: target_type = g_strdup(&type[5]); -target_type[strlen(target_type) - 2] = 0; +*strchr(target_type, '>') = 0; Should use an intermediate variable here and do a NULL check. My eyes can't handle dereferencing st

Re: [Qemu-devel] [PATCH v2 08/27] qom: fix off-by-one

2012-02-06 Thread Anthony Liguori
On 02/04/2012 02:02 AM, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini --- qom/object.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qom/object.c b/qom/object.c index b26272f..314fc7a 100644 --- a/qom/object.c +++ b/qom/object.c @@ -871,7 +871,7 @@ static void o

[Qemu-devel] [PATCH v2 08/27] qom: fix off-by-one

2012-02-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- qom/object.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qom/object.c b/qom/object.c index b26272f..314fc7a 100644 --- a/qom/object.c +++ b/qom/object.c @@ -871,7 +871,7 @@ static void object_set_link_property(Object *obj, Visitor *v