Re: [Qemu-devel] [PATCH v2 07/19] qapi: Avoid use of 'data' member of qapi unions

2016-03-02 Thread Markus Armbruster
Eric Blake writes: > qapi code generators currently create a 'void *data' member as QAPI > part of the anonymous union embedded in the C struct corresponding > to a qapi union. However, directly assigning to this member of QAPI > the union feels a bit fishy, when we can directly use the rest

[Qemu-devel] [PATCH v2 07/19] qapi: Avoid use of 'data' member of qapi unions

2016-02-25 Thread Eric Blake
qapi code generators currently create a 'void *data' member as part of the anonymous union embedded in the C struct corresponding to a qapi union. However, directly assigning to this member of the union feels a bit fishy, when we can directly use the rest of the struct instead. Signed-off-by: Eri