Re: [Qemu-devel] [PATCH v2 07/14] ui/vnc: Use qcrypto_random_bytes for make_challenge

2019-03-14 Thread Richard Henderson
On 3/14/19 2:43 PM, Philippe Mathieu-Daudé wrote: > On 3/14/19 4:39 PM, Daniel P. Berrangé wrote: >> On Wed, Mar 13, 2019 at 09:55:19PM -0700, Richard Henderson wrote: >>> static void make_challenge(VncState *vs) >>> { >>> -int i; >>> - >>> -srand(time(NULL)+getpid()+getpid()*987654+rand(

Re: [Qemu-devel] [PATCH v2 07/14] ui/vnc: Use qcrypto_random_bytes for make_challenge

2019-03-14 Thread Philippe Mathieu-Daudé
On 3/14/19 4:39 PM, Daniel P. Berrangé wrote: > On Wed, Mar 13, 2019 at 09:55:19PM -0700, Richard Henderson wrote: >> Use a better interface for random numbers than rand, >> plus some useless floating point arithmetic. >> >> Cc: Gerd Hoffmann >> Signed-off-by: Richard Henderson >> --- >> v2: Use

Re: [Qemu-devel] [PATCH v2 07/14] ui/vnc: Use qcrypto_random_bytes for make_challenge

2019-03-14 Thread Daniel P . Berrangé
On Wed, Mar 13, 2019 at 09:55:19PM -0700, Richard Henderson wrote: > Use a better interface for random numbers than rand, > plus some useless floating point arithmetic. > > Cc: Gerd Hoffmann > Signed-off-by: Richard Henderson > --- > v2: Use qcrypto_random_bytes, not qemu_getrandom, as there is

Re: [Qemu-devel] [PATCH v2 07/14] ui/vnc: Use qcrypto_random_bytes for make_challenge

2019-03-14 Thread Gerd Hoffmann
On Wed, Mar 13, 2019 at 09:55:19PM -0700, Richard Henderson wrote: > Use a better interface for random numbers than rand, > plus some useless floating point arithmetic. > > Cc: Gerd Hoffmann > Signed-off-by: Richard Henderson Reviewed-by: Gerd Hoffmann

[Qemu-devel] [PATCH v2 07/14] ui/vnc: Use qcrypto_random_bytes for make_challenge

2019-03-13 Thread Richard Henderson
Use a better interface for random numbers than rand, plus some useless floating point arithmetic. Cc: Gerd Hoffmann Signed-off-by: Richard Henderson --- v2: Use qcrypto_random_bytes, not qemu_getrandom, as there is no need for deterministic results for this interface. --- ui/vnc.c | 8 ++---