Re: [Qemu-devel] [PATCH v2 07/11] exec: check MRU in qemu_ram_addr_from_host

2013-07-02 Thread Paolo Bonzini
Il 02/07/2013 09:09, Jan Kiszka ha scritto: >> > >> > Right now there is hardly any documentation of what does _not_ require >> > the iothread mutex... basically everything except qemu_safe_ram_ptr and >> > qemu_ram_ptr_length requires it. > I don't disagree regarding the current state. But that

Re: [Qemu-devel] [PATCH v2 07/11] exec: check MRU in qemu_ram_addr_from_host

2013-07-02 Thread Jan Kiszka
On 2013-07-01 22:48, Paolo Bonzini wrote: > Il 01/07/2013 20:33, Jan Kiszka ha scritto: >>> This function is not used outside the iothread mutex, so it >>> can use ram_list.mru_block. >> >> Add a comment to qemu_ram_addr_from_host to document this requirement? > > Right now there is hardly any doc

Re: [Qemu-devel] [PATCH v2 07/11] exec: check MRU in qemu_ram_addr_from_host

2013-07-01 Thread Paolo Bonzini
Il 01/07/2013 20:33, Jan Kiszka ha scritto: > > This function is not used outside the iothread mutex, so it > > can use ram_list.mru_block. > > Add a comment to qemu_ram_addr_from_host to document this requirement? Right now there is hardly any documentation of what does _not_ require the iothrea

Re: [Qemu-devel] [PATCH v2 07/11] exec: check MRU in qemu_ram_addr_from_host

2013-07-01 Thread Jan Kiszka
On 2013-06-28 18:58, Paolo Bonzini wrote: > This function is not used outside the iothread mutex, so it > can use ram_list.mru_block. Add a comment to qemu_ram_addr_from_host to document this requirement? > > Signed-off-by: Paolo Bonzini > --- > exec.c | 12 ++-- > 1 file changed, 10 i

[Qemu-devel] [PATCH v2 07/11] exec: check MRU in qemu_ram_addr_from_host

2013-06-28 Thread Paolo Bonzini
This function is not used outside the iothread mutex, so it can use ram_list.mru_block. Signed-off-by: Paolo Bonzini --- exec.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/exec.c b/exec.c index 8722420..f3d7b18 100644 --- a/exec.c +++ b/exec.c @@ -1408,18 +1