Re: [Qemu-devel] [PATCH v2 06/54] qapi: introduce qapi_enum_lookup()

2017-08-24 Thread Dr. David Alan Gilbert
* Marc-André Lureau (marcandre.lur...@redhat.com) wrote: > Hi > > - Original Message - > > Marc-André Lureau writes: > > > > > This will help with the introduction of a new structure to handle > > > enum lookup. It would be good to make that comment explain why it's necessary. > > > Si

Re: [Qemu-devel] [PATCH v2 06/54] qapi: introduce qapi_enum_lookup()

2017-08-23 Thread Marc-André Lureau
Hi - Original Message - > Marc-André Lureau writes: > > > This will help with the introduction of a new structure to handle > > enum lookup. > > > > Signed-off-by: Marc-André Lureau > > --- > [...] > > 45 files changed, 206 insertions(+), 122 deletions(-) > > Hmm. > > > diff --git a/

Re: [Qemu-devel] [PATCH v2 06/54] qapi: introduce qapi_enum_lookup()

2017-08-23 Thread Markus Armbruster
Marc-André Lureau writes: > This will help with the introduction of a new structure to handle > enum lookup. > > Signed-off-by: Marc-André Lureau > --- [...] > 45 files changed, 206 insertions(+), 122 deletions(-) Hmm. > diff --git a/include/qapi/util.h b/include/qapi/util.h > index 7436ed815

Re: [Qemu-devel] [PATCH v2 06/54] qapi: introduce qapi_enum_lookup()

2017-08-22 Thread John Snow
On 08/22/2017 09:22 AM, Marc-André Lureau wrote: > This will help with the introduction of a new structure to handle > enum lookup. > Procedurally for the sake of review, it's a little odd to introduce the function, deploy it, and then change it and update all callers. content-wise, I'm really

[Qemu-devel] [PATCH v2 06/54] qapi: introduce qapi_enum_lookup()

2017-08-22 Thread Marc-André Lureau
This will help with the introduction of a new structure to handle enum lookup. Signed-off-by: Marc-André Lureau --- include/qapi/util.h | 2 + backends/hostmem.c | 3 +- block/backup.c | 3 +- block/file-posix.c | 5 ++-