Re: [Qemu-devel] [PATCH v2 06/20] iscsi: correctly propagate errors in iscsi_open

2014-02-14 Thread Stefan Hajnoczi
On Tue, Feb 11, 2014 at 06:03:39PM +0100, Paolo Bonzini wrote: > @@ -1349,14 +1350,15 @@ static int iscsi_reopen_prepare(BDRVReopenState > *state, > static int iscsi_truncate(BlockDriverState *bs, int64_t offset) > { > IscsiLun *iscsilun = bs->opaque; > -int ret = 0; > +Error *local

[Qemu-devel] [PATCH v2 06/20] iscsi: correctly propagate errors in iscsi_open

2014-02-11 Thread Paolo Bonzini
Before: $ ./qemu-io-old qemu-io-old> open -r -o file.driver=iscsi,file.filename=foo Failed to parse URL : foo qemu-io-old: can't open device (null): Could not open 'foo': Invalid argument After: $ ./qemu-io qemu-io> open -r -o file.driver=iscsi,file.filename=foo qemu-i