Re: [Qemu-devel] [PATCH v2 06/13] hw/misc/tz-mpc.c: Implement registers

2018-06-15 Thread Auger Eric
Hi Peter, On 06/15/2018 11:04 AM, Peter Maydell wrote: > On 14 June 2018 at 21:36, Auger Eric wrote: >> Hi Peter, >> >> On 06/04/2018 05:29 PM, Peter Maydell wrote: >>> Implement the missing registers for the TZ MPC. >>> >>> Signed-off-by: Peter Maydell > >>> +case A_INT_CLEAR: >>> +

Re: [Qemu-devel] [PATCH v2 06/13] hw/misc/tz-mpc.c: Implement registers

2018-06-15 Thread Peter Maydell
On 14 June 2018 at 21:36, Auger Eric wrote: > Hi Peter, > > On 06/04/2018 05:29 PM, Peter Maydell wrote: >> Implement the missing registers for the TZ MPC. >> >> Signed-off-by: Peter Maydell >> +case A_INT_CLEAR: >> +if (value & R_INT_CLEAR_IRQ_MASK) { >> +s->int_stat = 0

Re: [Qemu-devel] [PATCH v2 06/13] hw/misc/tz-mpc.c: Implement registers

2018-06-15 Thread Peter Maydell
On 15 June 2018 at 08:23, Auger Eric wrote: > Hi Peter, > > On 06/04/2018 05:29 PM, Peter Maydell wrote: >> Implement the missing registers for the TZ MPC. >> >> Signed-off-by: Peter Maydell >> +case A_BLK_LUT: >> +r = s->blk_lut[s->blk_idx]; >> +if (size == 4) { > don't you

Re: [Qemu-devel] [PATCH v2 06/13] hw/misc/tz-mpc.c: Implement registers

2018-06-15 Thread Peter Maydell
On 14 June 2018 at 21:14, Auger Eric wrote: > Hi Peter, > > On 06/04/2018 05:29 PM, Peter Maydell wrote: >> Implement the missing registers for the TZ MPC. >> >> Signed-off-by: Peter Maydell >> static MemTxResult tz_mpc_reg_read(void *opaque, hwaddr addr, >>

Re: [Qemu-devel] [PATCH v2 06/13] hw/misc/tz-mpc.c: Implement registers

2018-06-15 Thread Auger Eric
Hi Peter, On 06/04/2018 05:29 PM, Peter Maydell wrote: > Implement the missing registers for the TZ MPC. > > Signed-off-by: Peter Maydell > --- > include/hw/misc/tz-mpc.h | 10 +++ > hw/misc/tz-mpc.c | 137 ++- > 2 files changed, 144 insertions(+), 3

Re: [Qemu-devel] [PATCH v2 06/13] hw/misc/tz-mpc.c: Implement registers

2018-06-14 Thread Auger Eric
Hi Peter, On 06/04/2018 05:29 PM, Peter Maydell wrote: > Implement the missing registers for the TZ MPC. > > Signed-off-by: Peter Maydell > --- > include/hw/misc/tz-mpc.h | 10 +++ > hw/misc/tz-mpc.c | 137 ++- > 2 files changed, 144 insertions(+), 3

Re: [Qemu-devel] [PATCH v2 06/13] hw/misc/tz-mpc.c: Implement registers

2018-06-14 Thread Auger Eric
Hi Peter, On 06/04/2018 05:29 PM, Peter Maydell wrote: > Implement the missing registers for the TZ MPC. > > Signed-off-by: Peter Maydell > --- > include/hw/misc/tz-mpc.h | 10 +++ > hw/misc/tz-mpc.c | 137 ++- > 2 files changed, 144 insertions(+), 3

[Qemu-devel] [PATCH v2 06/13] hw/misc/tz-mpc.c: Implement registers

2018-06-04 Thread Peter Maydell
Implement the missing registers for the TZ MPC. Signed-off-by: Peter Maydell --- include/hw/misc/tz-mpc.h | 10 +++ hw/misc/tz-mpc.c | 137 ++- 2 files changed, 144 insertions(+), 3 deletions(-) diff --git a/include/hw/misc/tz-mpc.h b/include/hw/misc