Re: [Qemu-devel] [PATCH v2 06/11] aspeed/smc: fix default read value

2018-09-25 Thread Cédric Le Goater
On 9/25/18 2:24 PM, Peter Maydell wrote: > On 21 September 2018 at 17:19, Cédric Le Goater wrote: >> 0x should be returned for non implemented registers. >> >> Also, > > Use of "Also" in a commit message often indicates that it > would be better to split the commit. The two changes here >

Re: [Qemu-devel] [PATCH v2 06/11] aspeed/smc: fix default read value

2018-09-25 Thread Peter Maydell
On 21 September 2018 at 17:19, Cédric Le Goater wrote: > 0x should be returned for non implemented registers. > > Also, Use of "Also" in a commit message often indicates that it would be better to split the commit. The two changes here don't seem to me to have much to do with each other.

[Qemu-devel] [PATCH v2 06/11] aspeed/smc: fix default read value

2018-09-21 Thread Cédric Le Goater
0x should be returned for non implemented registers. Also, the model should expose one control register per possible CS even if there is no flash device attached. When testing the validity of the register number in the read operation, replace 's->num_cs' by 'ctrl->max_slaves' which represe