Re: [Qemu-devel] [PATCH v2 04/12] virtio-pci: remove vdev field

2013-10-15 Thread Michael S. Tsirkin
On Tue, Oct 15, 2013 at 06:42:25PM +0200, Paolo Bonzini wrote: > Il 15/10/2013 18:06, Michael S. Tsirkin ha scritto: > >> > It's not datapath if you're using ioeventfd, is it? > > Well not everyone uses dataplane/vhost. > > ioeventfd does not require dataplane/vhost. Anyway for 1.8 I do want to >

Re: [Qemu-devel] [PATCH v2 04/12] virtio-pci: remove vdev field

2013-10-15 Thread Paolo Bonzini
Il 15/10/2013 18:06, Michael S. Tsirkin ha scritto: >> > It's not datapath if you're using ioeventfd, is it? > Well not everyone uses dataplane/vhost. ioeventfd does not require dataplane/vhost. Anyway for 1.8 I do want to get rid of BusChild altogether, just not now. Paolo > It's the same for

Re: [Qemu-devel] [PATCH v2 04/12] virtio-pci: remove vdev field

2013-10-15 Thread Michael S. Tsirkin
On Tue, Oct 15, 2013 at 05:53:39PM +0200, Paolo Bonzini wrote: > Il 15/10/2013 17:40, Michael S. Tsirkin ha scritto: > > On Tue, Oct 15, 2013 at 04:52:45PM +0200, Paolo Bonzini wrote: > >> > @@ -257,7 +271,7 @@ static void virtio_pci_stop_ioeventfd(VirtIOPCIProxy > >> > *proxy) > >> > static void

Re: [Qemu-devel] [PATCH v2 04/12] virtio-pci: remove vdev field

2013-10-15 Thread Paolo Bonzini
Il 15/10/2013 17:40, Michael S. Tsirkin ha scritto: > On Tue, Oct 15, 2013 at 04:52:45PM +0200, Paolo Bonzini wrote: >> > @@ -257,7 +271,7 @@ static void virtio_pci_stop_ioeventfd(VirtIOPCIProxy >> > *proxy) >> > static void virtio_ioport_write(void *opaque, uint32_t addr, uint32_t val) >> > { >

Re: [Qemu-devel] [PATCH v2 04/12] virtio-pci: remove vdev field

2013-10-15 Thread Michael S. Tsirkin
On Tue, Oct 15, 2013 at 04:52:45PM +0200, Paolo Bonzini wrote: > @@ -257,7 +271,7 @@ static void virtio_pci_stop_ioeventfd(VirtIOPCIProxy > *proxy) > static void virtio_ioport_write(void *opaque, uint32_t addr, uint32_t val) > { > VirtIOPCIProxy *proxy = opaque; > -VirtIODevice *vdev =

[Qemu-devel] [PATCH v2 04/12] virtio-pci: remove vdev field

2013-10-15 Thread Paolo Bonzini
The vdev field is complicated to synchronize. Just access the BusState's list of children. Cc: qemu-sta...@nongnu.org Signed-off-by: Paolo Bonzini --- hw/virtio/virtio-pci.c | 110 + hw/virtio/virtio-pci.h | 1 - 2 files changed, 65 insertions(+