Re: [Qemu-devel] [PATCH v2 04/10] vnc: switch to QemuOpts, allow multiple servers

2014-12-11 Thread Gerd Hoffmann
Hi, > > +fprintf(stderr, "%s: id \"%s\"\n", __func__, id); > > A debug message, isn't it? Yes, dropped. > > + > > +vnc_display_init(id); > > +vnc_display_open(id, &local_err); > > +if (local_err != NULL) { > > +error_report("Failed to start VNC server on `%s': %s", > >

Re: [Qemu-devel] [PATCH v2 04/10] vnc: switch to QemuOpts, allow multiple servers

2014-12-10 Thread Gonglei
On 2014/12/10 17:37, Gerd Hoffmann wrote: > This patch switches vnc over to QemuOpts, and it (more or less > as side effect) allows multiple vnc server instances. > > Signed-off-by: Gerd Hoffmann > --- > include/ui/console.h | 4 +- > qmp.c| 15 ++- > ui/vnc.c | 2

[Qemu-devel] [PATCH v2 04/10] vnc: switch to QemuOpts, allow multiple servers

2014-12-10 Thread Gerd Hoffmann
This patch switches vnc over to QemuOpts, and it (more or less as side effect) allows multiple vnc server instances. Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 4 +- qmp.c| 15 ++- ui/vnc.c | 271 --- vl.