Re: [Qemu-devel] [PATCH v2 03/34] tests/qgraph: pci-pc driver and interface nodes

2018-08-09 Thread Laurent Vivier
On 09/08/2018 14:33, Emanuele wrote: > Ok, makes sense for qpci_device_init, but I still need to perform that > check for qpci_device_find. Yes, you're right. Thanks, Laurent

Re: [Qemu-devel] [PATCH v2 03/34] tests/qgraph: pci-pc driver and interface nodes

2018-08-09 Thread Emanuele
On 08/09/2018 02:29 PM, Laurent Vivier wrote: On 09/08/2018 14:17, Emanuele wrote: +    return TRUE; +} + +QPCIDevice *qpci_device_find(QPCIBus *bus, int devfn) +{ +    QPCIDevice *dev; + +    dev = g_malloc0(sizeof(*dev)); + +    if (!qpci_device_set(dev, bus, devfn)) {   g_free(dev

Re: [Qemu-devel] [PATCH v2 03/34] tests/qgraph: pci-pc driver and interface nodes

2018-08-09 Thread Laurent Vivier
On 09/08/2018 14:17, Emanuele wrote: > >>> +    return TRUE; >>> +} >>> + >>> +QPCIDevice *qpci_device_find(QPCIBus *bus, int devfn) >>> +{ >>> +    QPCIDevice *dev; >>> + >>> +    dev = g_malloc0(sizeof(*dev)); >>> + >>> +    if (!qpci_device_set(dev, bus, devfn)) { >>>   g_free(dev); >>>

Re: [Qemu-devel] [PATCH v2 03/34] tests/qgraph: pci-pc driver and interface nodes

2018-08-09 Thread Emanuele
+return TRUE; +} + +QPCIDevice *qpci_device_find(QPCIBus *bus, int devfn) +{ +QPCIDevice *dev; + +dev = g_malloc0(sizeof(*dev)); + +if (!qpci_device_set(dev, bus, devfn)) { g_free(dev); return NULL; } @@ -66,6 +83,21 @@ QPCIDevice *qpci_device_find(QPCI

Re: [Qemu-devel] [PATCH v2 03/34] tests/qgraph: pci-pc driver and interface nodes

2018-08-08 Thread Laurent Vivier
On 06/08/2018 16:33, Emanuele Giuseppe Esposito wrote: > Add pci-bus-pc node, move QPCIBusPC struct declaration in its header > (since it will be needed by other drivers) and introduce a setter method > for drivers that do not need to allocate but have to initialize QPCIBusPC. > > Signed-off-by: E

[Qemu-devel] [PATCH v2 03/34] tests/qgraph: pci-pc driver and interface nodes

2018-08-06 Thread Emanuele Giuseppe Esposito
Add pci-bus-pc node, move QPCIBusPC struct declaration in its header (since it will be needed by other drivers) and introduce a setter method for drivers that do not need to allocate but have to initialize QPCIBusPC. Signed-off-by: Emanuele Giuseppe Esposito --- tests/Makefile.include | 4 +++-