Re: [Qemu-devel] [PATCH v2 03/15] qdev_prop_parse(): extend signature with Error

2013-02-07 Thread Luiz Capitulino
On Thu, 7 Feb 2013 15:04:54 -0200 Eduardo Habkost wrote: > On Tue, Feb 05, 2013 at 09:39:16PM +0100, Laszlo Ersek wrote: > > Error handling is not changed yet. > > > > Signed-off-by: Laszlo Ersek > > The extra parameter seems useless and even misleading (because Error > info won't be set even

Re: [Qemu-devel] [PATCH v2 03/15] qdev_prop_parse(): extend signature with Error

2013-02-07 Thread Eduardo Habkost
On Tue, Feb 05, 2013 at 09:39:16PM +0100, Laszlo Ersek wrote: > Error handling is not changed yet. > > Signed-off-by: Laszlo Ersek The extra parameter seems useless and even misleading (because Error info won't be set even if the function returns -1) without patch 04/15. What about squashing bot

[Qemu-devel] [PATCH v2 03/15] qdev_prop_parse(): extend signature with Error

2013-02-05 Thread Laszlo Ersek
Error handling is not changed yet. Signed-off-by: Laszlo Ersek --- hw/qdev-properties.h |4 +++- hw/qdev-monitor.c|2 +- hw/qdev-properties.c |5 +++-- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/hw/qdev-properties.h b/hw/qdev-properties.h index 20c67f3..0fe403